Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__proto__ disappears from the inverted index if you serialize an index that was loaded from a serialized JSON blob #378

Merged
merged 2 commits into from
Oct 16, 2018
Merged

__proto__ disappears from the inverted index if you serialize an index that was loaded from a serialized JSON blob #378

merged 2 commits into from
Oct 16, 2018

Commits on Oct 13, 2018

  1. Test that __proto__ is indexed across two serializations 

    I found while using lunr that __proto__ can slip through the
serialization process if you're serializing an index that was
itself loaded from a serialized index - it might not be a bad idea
to make sure that serializing an index loaded from a JSON blob
serializes to the exact same JSON blob (well, forgiving things like
a change in the order of the keys)
    @hoelzro
    hoelzro committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    549ebd5 View commit details
    Browse the repository at this point in the history

  2. Load inverted index into a prototype-less object 

    Fixes the issue where __proto__ is dropped from the inverted index
after a second deserializatoin
    @hoelzro
    hoelzro committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    355aa15 View commit details
    Browse the repository at this point in the history