-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deluge 2 Support #50
Comments
Looks like there is an updated version here: https://github.com/kslr/deluge-autoremoveplus/ Unfortunately, it does not appear to compile without errors on python 3.7 It looks like kslr started working on updating it and gave up shortly after..... |
I just submitted a pull request. Here is the egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip |
Appears to be working. I do have many torrents to do a full test on it right now, but it appears to be good to go! Will update this or the pull request if I encounter any issues. |
It didn't work for me :-( |
Me neither, although it seems like the webui plugin upload thing isn't quite working properly in deluge for me... |
I can confirm it is still working for me, including exemptions. I manually put the plugin .egg into the plugins directory and restarted deluge. I did not use the WebUI plugin upload functionality. EDIT: I did download the link from here I believe the link above in this thread used to be a broken version, but he edited it for the fixed version. |
Tried installing manually and deluge throws the following error as soon as I click to enable it.
|
The error appears to come from an issue outside the scope of this plugin. If the plugin is unable to find the core module, then there are bigger issues at play. Please try a clean install/config/image depending on your setup, and make sure that you're using the most recent egg -- my edit in my previous comment changed the link to a build of an updated commit. Here is the most up-to-date egg: https://github.com/omaralvarez/deluge-autoremoveplus/files/3312651/AutoRemovePlus-0.6.2-py3.7.zip |
I am using the linuxserver/deluge docker image, which is a very popular distribution of deluge (has over 10 million pulls), and it's on docker so it's pretty much consistent across all it's users, and therefore easy to recreate. Dropping the egg into the plugins folder doesn't work, although I have no errors in the logs either. |
I am familiar with both the linuxserver/deluge and binhex/arch-delugevpn images as well as the checksum-verified consistency of Docker images. Nevertheless, everyone has different configs that may have all sorts of effects. |
I had "enabled_plugins": ["Label", "AutoRemovePlus"], but no sign of the plugin working or appearing in the preferences page. |
Is there a difference between the enabled_plugins values in core.conf~ and core.conf? Or did they both contain Label and AutoRemovePlus without needing to make any changes? |
Nothing in the logs. I added it to the core.conf~ file manually it wasn't there. Although my understanding was that file was just a backup anyway? The core.conf~ file's last modified date was a long time ago for me. |
I'm rebuilding my media server so this is a new computer, fresh OS/Deluge install, First 3rd-party plugin to be installed. DISTRIB_DESCRIPTION="Ubuntu 19.04" deluge-common/disco,now 2.0.3-2 I'll give the latest egg a try... |
Yes, core.conf~ is a backup. In my experience, sometimes there's an inexplicable difference between what Deluge loads and what core.conf says it should load. My guess was that it failed to use core.conf and fell back to using core.conf~, but this is most likely not the case. It is my own habit to add the plugins to both files.
Nevermind, those versions listed are 2.0.3, up to date. Not sure what else could be causing this. Although it still may be worth checking if you're installing from the official Ubuntu repository or the Deluge PPA. |
Try
If it's 3.6.8, rename the file to
|
Hey everyone, reporting in using Deluge 2.0.3 in a docker container based off of the archlinux/delugevpn image. Just used the latest AutoRemovePlus-0.6.2-py3.7 manually placed it in my plugins directory and rebooted deluge. The plugin showed up in the list and is working as expected. Great work. |
If you're using the |
I pulled your egg and have it installed on the GTK version of Deluge, however I'm not sure how to config. I don't get a config option in the menu and the .conf is unfortunately not very clear. I don't mind just using the .conf directly if you can clarify the options. |
I can't get this egg to install at all. I did it through the web interface first, and the plugin didn't show up. Then I did it through the gui and still doesn't show up in the plugin list. I copied the egg to the plugins folder and restarted deluge, and that didn't work either. I'm running it on Ubuntu 19. Any ideas as to what I'm doing wrong? |
Check your python version. If you're on 3.6 you'll have to rename the egg. |
I had just fixed it and was typing it up when you posted that. The Python version fixed it. That said, are the settings supposed to show up in the GUI or is it supposed to be all manually editing the config files? |
Should show up in the web UI, yeah. You might have to enable it first under the plug-in menu. |
I did that. And the plugin is definitely working(I used the old 1.x config file for it). But it just doesn’t show up in options. |
I have the plugin at least theoretically working, but in the standalone GTK client the options menu doesn't appear (the "built-in" plugins do appear when selected). Is there any info on how to just hand craft the .conf, or a solution to make the menu appear? |
Does anyone else have a problem where the items don't actually get removed until you log into Deluge? For example, when I try to delete a downloaded file from the file system, I can't delete it because it's in use. So I log into Deluge, and I see it for a few seconds and then it disappears, and then I can delete it from the system. |
Having a problem where this plugin doesn't remove anything. Same settings as with deluge 1.3.16. I see :39:29 [WARNING ][deluge.plugin.autoremoveplus.core:133 ] check interval loop starting in the log once I restart the docker, and never again. |
Same here. The .conf from the previous version seems to work fine for me though. I'd suggest installing deluge 1.0, grabbing the old version of the .egg, creating the config you want, then converting to deluge 2.0 until the settings page is updated. Incredibly poor work around, but it's better than trying to figure out the .conf syntax. |
I have the exact same problem! It works once and then when the docker container restarts it never does what it's supposed to until you manually change the settings and apply again. Can the devs comment here please? |
I could update the plugin for python 3.7 and deluge 2, but there are just two problems:
|
@springjools 2 things need to be addressed with your version of the egg. python-future dependency and new corrupt config generation where the config has missing key pair values for sonnar, radarr and lidarr. |
Are you commenting on the latest version of the plugin, ie 0.6.7?
Because i added a check like that on the second point you write about.
…Sent from my iPhone
On 30 Nov 2019, at 10:17, Adam ***@***.***> wrote:
@springjools 2 things need to be addressed with your version of the egg. python-future dependency and new corrupt config generation where the config has missing key pair values for sonnar, radarr and lidarr.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@springjools Hello. I also tried out that plugin in my Deluge. Same issue, I enable it and it disables itself. (Version 0.6.7). |
Are you aware of this: https://dev.deluge-torrent.org/ticket/3335 |
I also have that issue. Torrents dont delete unless I connect to the gui, open the plugin settings and click apply. Then torrents delete. Any idea for a fix? @springjools I think that link is for the "built-in" method for deleting torrents and not for this plugin. |
@shadycuz : The plugin uses the built-in method to delete torrents. See: |
@springjools aha I see. So they are probably all being queued up to be deleted, but it's not working unless you have the web gui open. =/ |
Do you have anything in the logs? This plugins writes in the log when the removal happens. |
I am having issues when trying to install autoremoveplus to a binhex-deluge 2.0.3 docker container. Whenever I try and add the 0.6.8 (or 0.6.7 and 0.6.6) egg, it doesn't show up in the plugins. Am I doing something incorrectly? |
Check what the logs say. |
There doesn't seem to be anything in the logs. I have just setup the deluge container, so I am a bit new to this. I am running it in unraid, and when I check the log icon next to the container, it never references the .egg file or plugins in general. |
Yes! Thank you. |
For those having issues on linuxserver/deluge with enabling the plugin going in and out and its unticked. |
That's weird. I did not have to do that and it worked on my container. |
Not really a good idea @teflocarbon. Containers are temporary and once the image will be updated you will loose the packages that you installed manually. |
That's very easy to solve with LSIO containers: https://blog.linuxserver.io/2019/09/14/customizing-our-containers/ |
I think it's better to upstream the command to the initial image than doing it the hacky way. |
Well, yes, of course that's the best way but that's up to the LSIO team to do it. In my case, I did not need to install anything to make the plugin work so I'm not sure if installing it is even applicable for all. I'm just saying that if you have to do any customization to their containers, you can easily but a two-liner sh script in the |
its definitely a hacky way, I agree. The appropriate way would be to fork it and do it yourself to the base image or create a pull request with the change. |
@teflocarbon So based on this post only the python3-requests module is needed. Are you saying that you need to update it? And is the python3-future module really needed? |
That's right. Only requests is needed. There's a requirements.txt that you can use as well. It's recommended that you also use the latest version of twisted, which is 20.3.0, if you want to be compatible with python 3.8 (because there's some error spam from earlier versions of twisted related to the logger module). |
Ok. How do you exactly use the requirements.txt that you have on your branch? Are you saying to just use it as a reference, manually? Or is there some automation that I can do? Sorry, I'm not a Linux expert. Also, I just installed python3-requests on the LSIO docker container but this is the latest module I got: python3-requests/bionic-updates,bionic-security,now 2.18.4-2ubuntu0.1 all [installed] In your requirements.txt, you have these:
So obviously, I have a lower version of requests installed even though I just installed it. I made sure to update the apt repository of course. |
"pip3 install -r requirements.txt" |
I don't think the requests matter so much, but using an old twisted and python 3.8 causes log spams. You may need to forcefully install latest twisted using the command: |
Well, the thing is that LSIO's docker container uses python 3.6.9. So I really don't need to update the old twisted, do I? |
Nope, but eventually it will use python 3.8 right? |
Yeah, I suppose so. It also doesn't have pip3. Do I need to manually install that or something? I almost always use just apt to install/remove things. |
pip comes with python. On linux the relevant commands seem to be python3 and pip3 instead of the plain versions. In case you cannot use pip directly because of rights/other issues you can launch pip with the command 'python -m pip' or 'python3 -m pip'. Actually, if you upgrade to python 3.8 you also need to upgrade to deluge 2.04.dev24, since the issue with the new syntax for the logger module is fixed there. My experience is that deluge is a bit slow to upgrade things. |
|
Hmmm, weird. Can you test any of the fixes on this page: |
With Deluge 2 out, can we get this plugin updated to python 3 so we can use it?
The text was updated successfully, but these errors were encountered: