-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1080p and other video support #34
Comments
Also note that 480p video resolution is not supported currently too, as well as 720p @ webm. |
Just thought I'd update folks on this. VideoJS provides ways to manage tracks, but not to play them unless they're already contained within the video file, which unfortunately they are not in this case. VideoJS leaves it up to other plugins, like videojs-contrib-hls to manage playback of multiple streams. Currently I'm working on getting the video streams into a format that one of those plugins should support. |
Hopefully the last update before this is added: Invidious can generate working DASH manifests for most videos, which means all that needs to be implemented is support on the client-side. For that the only missing piece appears to be videojs/http-streaming#162 so that VideoJS can play properly play manifests and integrate them into speed control, quality selector, etc. |
@omarroth |
Added experimental 1080p with b3ca392. You can enable it if you're logged in by going to your preferences and selecting Currently the main interest with pushing out DASH support is to find any errors in playback namely buffer speed and bandwidth usage. Please feel free to open an issue if you encounter any errors or if dash support is missing from any videos. |
How is the status? |
Hi! This is waiting on videojs/http-streaming#455. I haven't mentioned this much since I don't want to put any pressure on the great folks working on that project. Once that's been implemented expect progress on this issue to start moving much more quickly. The reason it requires a way to "opt-in" is because it includes a much larger library in order to play 1080p. I'm waiting on http-streaming since it's already used for livestreams and is roughly 1/5th the size of the library I'm currently using to implement this feature. |
Just pushed a fix that allows you to specify |
Suuuper nice! Really awesome to see this project evolving. Dash playback is broken for me though on both FF and Edge. Only sound, no video. |
Other folks have been encountering that as well. It appears that YouTube is trying out new codecs that aren't supported by default in all browsers. You might try enabling See here for some more info. |
Works great. Thanks! |
Added source selector with 075adb4 so it should now be possible to select quality for 1080p streams and higher with dash enabled. |
I test with that video: https://invidio.us/watch?v=Bey4XXJAqS8&quality=dash |
Thank you! It works really well for me. Although I've found a couple of bugs with it:
Also, the video in #333 now fails to play altogether, as there's no falling back to another source. |
I'm truly amazed how this project develops! Since dash support got introduced, not even a connection to google is needed anymore, according to umatrix. How does that even work? I presume it just redirects somehow to googlevideo.com through invidio.us? Invidious even supports 60fps through DASH, but you can't explicitly select it, it gets auto selected with 720 and 1080. I swear I saw it selecting 30 instead of 60 from time to time. I can't pin down why (tested different browsers and connections), but sometimes the quality selection is pretty wonky, acting as a Soft hint for Auto and not a hard constraint quality selection. |
@SairesArt the video is proxied through invidious, so you don't have to connect to Google. |
Would it be possible to set the "dash" to 1080p by default and not "auto"? Do you plan to add support for 2160p (4K) and 1440p (2K) video? Thank you. 😊 |
With a "bad" (~3-6Mbit/s) connection you cannot stream 1080p on invidious with waiting for the loading screen.
Maybe a setting option but not default please.
…On July 1, 2019 4:31:08 PM UTC, AntoineD ***@***.***> wrote:
Would it be possible to set the "dash" to 1080p by default and not
"auto"?
Do you plan to add support for 2160p (4K) and 1440p (2K) video?
Thank you. :blush:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#34 (comment)
|
In NewPipe we display a combination of dash and nondash videos. Could this be something considerable as well? |
I also second this suggestion but maybe with a configurable dash quality (user choice) and not set only to 1080 but to the quality user chooses. so that user can set the video to dash and ,say, 720 and then by default the invidious instance plays at that quality without checking internet connection. btw can other codecs be supported? like vp9 and av1? both of these have higher quality picture (on youtube) that even me with my not 20-20 vision can see. |
This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked. |
Bump |
More recent versions of VideoJS seems to support more formats, but since quality selection is unfortunately broken on them, we can't upgrade. |
Every invidious instances offer high resolutions, not sure why you are being specific on this instance. |
Sorry, my bad. I am new to invidious and hadn't discovered the "dash" setting. Letting me to believe that 720p is the maximum resolution. Reading now more of the previous comments in this open issue, I saw were my misunderstanding was. |
Don't worry it's understandable, we have plans to merge all of these video settings because it creates confusion for the new users. |
thank you for all the the great efforts for progress of this project. |
1080p+ support is available when dash is enabled. |
Users should be able to freely choose between all available video resolutions, and not just those that have bundled audio.
Example video: https://invidio.us/watch?v=x47Ins_rkgk
VideoJS provides ways to add extra tracks, and all formats are served via
adaptive_fmts
in/get_video_info
.Maybe utilize
&bitrate=
and&resolution=
options (for audio and video, respectively) if&quality=
is not present?The text was updated successfully, but these errors were encountered: