Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend workflow to upload built JAR as a CI artifact #9

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Oct 1, 2021

Discussed as part of today's call re the testing of #8, this PR proposes a simple modification to the GitHub workflow to upload the JAR built under target as an artifact.

While I was enabling this, I realized that the current POM packages everything as a 65 MB uber JAR. I assume this is not strictly necessary but rather a convenience. In the same spirit as #8 (comment), can we think of a simpler scenario where only this component would be packaged and could be simply dropped into either the command-line tools and/or the ImageJ/Fiji distribution?

@joshmoore joshmoore mentioned this pull request Nov 8, 2021
@joshmoore
Copy link
Member

Captured the size reduction as #10. Merging to see if this can be used to improve the testing of #8.

@joshmoore joshmoore merged commit 6ae40f7 into ome:main Nov 8, 2021
@sbesson sbesson deleted the artifact branch November 8, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants