Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should support proxy settings #296

Open
dominikl opened this issue Jul 21, 2021 · 6 comments · May be fixed by ome/omero-blitz#119
Open

CLI should support proxy settings #296

dominikl opened this issue Jul 21, 2021 · 6 comments · May be fixed by ome/omero-blitz#119

Comments

@dominikl
Copy link
Member

See Omero-py and proxy settings.
The CLI would just have to pass ICE variables through to the Blitzgateway. Something similar was done for Insight: ome/omero-insight#197 .

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-py-and-proxy-settings/55456/2

@joshmoore
Copy link
Member

I assumed that omero/client.java would make use of system properties that were set with JAVA_OPTS=-DIce... but that looks to be server-side only. I imagine that would be a fairly easy workaround.

@dominikl
Copy link
Member Author

dominikl commented Aug 5, 2021

Does that mean, something like this (setting a wrong proxy) shouldn't work:

> export JAVA_OPTS=-DIce.HTTPProxyHost=1.2.3.4
> omero login

It does work, so the proxy setting is not taken into account, right?

@joshmoore
Copy link
Member

Right. https://github.com/ome/omero-blitz/blob/master/src/main/java/omero/client.java#L361 or so would need to be updated to either place all the System properties inside the Ice properties or perhaps rather just the ones matching Ice.* and omero.*.

@dominikl
Copy link
Member Author

Is it somehow possible to build omero-py with a custom omero-blitz, in order to test changes in omero-blitz? The setup.py seems to download omero-blitz from artifacts.openmicroscopy.org.

@joshmoore
Copy link
Member

Definitely. That's what merge-ci does:

def get_blitz_location():

    config_blitz_version = "5.5.5"

    # simplified strings
    defaultsect = configparser.DEFAULTSECT
    version_key = "versions.omero-blitz"
    url_key = "versions.omero-blitz-url"

    # detect if in Jenkins or not
    if "JENKINS_URL" in os.environ:
        config_blitz_url = os.environ.get("JENKINS_URL")
        config_blitz_url += "job/OMERO-build-build/lastSuccessfulBuild/"
        config_blitz_url += "artifact/omero-blitz/build/distributions/"
        config_blitz_url += "omero-blitz-VERSION-python.zip"
    else:
        config_blitz_url = (
            "https://artifacts.openmicroscopy.org/artifactory/ome.releases/"
            "org/openmicroscopy/omero-blitz/VERSION/"
            "omero-blitz-VERSION-python.zip")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants