Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value language labels #39

Closed
gdostal opened this issue Dec 28, 2021 · 1 comment
Closed

Value language labels #39

gdostal opened this issue Dec 28, 2021 · 1 comment

Comments

@gdostal
Copy link
Contributor

gdostal commented Dec 28, 2021

The theme does not seem to honor the core site setting: Show language labels for values

Language labels are always shown using foundation-s theme regardless of how the above is set. Omeka default theme does honor this setting, toggling the display of the language labels.

This seems to be related to this theme's override of /view/common/resource-values.phtml. I was able to resolve the issue by merging Omeka core's resrouce-values.phtml with foundation-s'. Example here.

How can I best help? Contribute a PR, or simply paste in my code below.

kimisgold added a commit that referenced this issue Mar 23, 2022
@kimisgold
Copy link
Collaborator

Thanks for reporting this, as well as your patience waiting for resolution. I'm updating the resource value override, and the fix should be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants