Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S 4.0: sort-selector partial not updated to match core changes #50

Closed
zerocrates opened this issue Jan 30, 2023 · 1 comment
Closed
Assignees

Comments

@zerocrates
Copy link
Contributor

The sort-selector.phtml in the core changed a little in S 4.0, but Foundation has a custom one that isn't updated for those changes. What actual changes did Foundation need to make here? Could we drop the override possibly?

Relatedly, core views now use the browse() helper to provide the default sort options rather than having them written into the theme view, so we might as well update to have that as well (doing this doesn't affect what's needed for sort-selector.phtml though).

@kimisgold
Copy link
Collaborator

Fixed in v1.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants