Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE-2020-26235] CVE Mitigation removing time@0.1.45 subdependency #10

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

voidbar
Copy link
Contributor

@voidbar voidbar commented Aug 8, 2023

Removed default features for chrono in order to eliminate subdependency on time@0.1.45. Removing this subdependency is required by an advisory here (CVE-2020-26235).

@voidbar
Copy link
Contributor Author

voidbar commented Aug 8, 2023

Also, I noticed that the azure dev ops pipeline doesn't work anymore, i took the liberty of adding a modern github actions ci pipeline. Running pipeline can be seen under my repo: https://github.com/voidbar/winstructs/actions/runs/5797917294/job/15714537093

@voidbar
Copy link
Contributor Author

voidbar commented Aug 10, 2023

@omerbenamram @forensicmatt could you please take a look?
Thanks

@omerbenamram
Copy link
Owner

omerbenamram commented Aug 10, 2023

hi @voidbar, thanks for the PR, I haven't touched the library in a while, but this looks good. Thanks!

@omerbenamram omerbenamram merged commit d6d3bd1 into omerbenamram:master Aug 10, 2023
@voidbar
Copy link
Contributor Author

voidbar commented Aug 13, 2023

@omerbenamram Thanks for the merge Omer.
Would it be possible for you to:

  1. Push the new version to crates
  2. Activate github actions on the repo

I would do it myself but I don't have permissions to do so
Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants