Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is averaging over overlapping regions necessary? #21

Open
yxchng opened this issue Aug 1, 2023 · 2 comments
Open

Why is averaging over overlapping regions necessary? #21

yxchng opened this issue Aug 1, 2023 · 2 comments

Comments

@yxchng
Copy link

yxchng commented Aug 1, 2023

Why can't we just do non-overlapping generation without averaging? I presume you have tried and found that averaging gives better results. Is there any intuition or theory for that?

@bishalsahooviga
Copy link

Can you suggest ways to to average and overlap masks? I went through the paper and the codes but I think I missed some important part.

@stanifrolov
Copy link

Hello @yxchng, this is a great question that I had as well. The averaging between overlapping regions is necessary to create a coherent and smooth transition between the individual denoised patches. However, it turns out that you can also simply shift non-overlapping denoising windows through the timesteps such that borders in one timestep are corrected in the next which results in faster image generation, see our analysis here https://spotdiffusion.github.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants