test: add test checking that inputs can not be exited from restarted ife after outputs finalized on processing the first ife #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ife after outputs finalized on processing the first ife
boolafish
reviewed
Apr 2, 2020
plasma_framework/python_tests/tests/contracts/root_chain/test_process_exits.py
Outdated
Show resolved
Hide resolved
plasma_framework/python_tests/tests/contracts/root_chain/test_process_exits.py
Outdated
Show resolved
Hide resolved
plasma_framework/python_tests/tests/contracts/root_chain/test_process_exits.py
Show resolved
Hide resolved
kevsul
reviewed
Apr 2, 2020
plasma_framework/python_tests/tests/contracts/root_chain/test_process_exits.py
Show resolved
Hide resolved
pgebal
force-pushed
the
pgebal/test_restart_ife_scenario
branch
from
bc2a6fb to
00e9bfc
Compare
kevsul
previously approved these changes
Apr 2, 2020
boolafish
previously approved these changes
Apr 2, 2020
There was a problem hiding this comment.
hmm...not really the direction that I was hoping to add comments. I was hoping sth like
def test_after_canonical_ife_is_finalized_inputs_are_not_exited_when_ife_is_restarted_and_non_canonical(testlang, plasma_framework, token):
"""
1. Alice sends fund to Bob
2. Bob blablablab
3. Alice blablabla
"""
# code starting here
....instead of inline comment on code.
But aside from this LGTM.
kevsul
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.