You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Thank you for your cool shopping cart :)
I'm not sure, but there is a bug in method
/**
* Removes position from the cart
* @param CartPositionInterface $position
*/
public function remove($position)
{
$this->removeById($position->id);
}
There should be $position->getId() instead of $position->id, because in case of composite id such as md5(serialize([$this->id, $this->price, $this->color])) you cannot properly remove item from cart just by $this->id.
Maybe I'm wrong, of course. Anyway thank you for reading all that above!
The text was updated successfully, but these errors were encountered:
Hi! Thank you for your cool shopping cart :)
I'm not sure, but there is a bug in method
There should be $position->getId() instead of $position->id, because in case of composite id such as md5(serialize([$this->id, $this->price, $this->color])) you cannot properly remove item from cart just by $this->id.
Maybe I'm wrong, of course. Anyway thank you for reading all that above!
The text was updated successfully, but these errors were encountered: