Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove item #14

Closed
drSun opened this issue Jun 15, 2015 · 1 comment
Closed

Remove item #14

drSun opened this issue Jun 15, 2015 · 1 comment

Comments

@drSun
Copy link

drSun commented Jun 15, 2015

Hi! Thank you for your cool shopping cart :)
I'm not sure, but there is a bug in method

    /**
     * Removes position from the cart
     * @param CartPositionInterface $position
     */
    public function remove($position)
    {
        $this->removeById($position->id);
    }

There should be $position->getId() instead of $position->id, because in case of composite id such as md5(serialize([$this->id, $this->price, $this->color])) you cannot properly remove item from cart just by $this->id.

Maybe I'm wrong, of course. Anyway thank you for reading all that above!

@omnilight
Copy link
Owner

Yes, you are right, closed with a353090
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants