Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox extension] 'You are not logged in' when logged in to Onminvore on a Firefox Multi-Account Container tab #2000

Closed
stoic-cat opened this issue Apr 7, 2023 · 6 comments
Assignees

Comments

@stoic-cat
Copy link

Description

Trying to save an article when already logged in to Omnivore in a firefox mult-account container tab results in a confusing 'You are not logged in' message.

Reproduction steps

  1. Log in to Omnivore in any firefox container tab
  2. Click on Omnivore extension
  3. Error message shows up

Screenshots

Screenshot from 2023-04-07 13-45-40

Solutions/Workarounds

The issue here is that I was not logged in to Omnivore in a non container tab and Omnivore probably has problems trying to read cookies of containers. There are 2 ways I can currently think of:

  • Log in to Omnivore on the default tab. - I prefer not to do this as I am using Firefox containers to segregate my cookies and browsing activity from one another.
  • Allow configuration of credentials via extension preferences, similar to how Wallabag's Firefox extension authenticates to the backend. - This also allows us a place to specify a different endpoint for those who want to self host Improve support for users that want to deploy their own backened #25

Thanks!

@jacksonh
Copy link
Contributor

jacksonh commented Apr 7, 2023

Thanks, allowing users to paste in an API key is a good idea. I had been wondering about a solution to this issue.

@jacksonh
Copy link
Contributor

Some notes on this:

need to add this to the manifest: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_ui

  "options_ui": {
    "page": "options.html",
    "open_in_tab": true
  },

From what I can tell we have three options for storing the key:

  • extension storage: can only be access by extension, isn't encrypted on disk but most users have full disk encryption now
  • file: would mean the extension needs file permissions, which might be a larger security concern
  • memory only: user would have to update occasionally

@thelazyoxymoron
Copy link

+1

We can take a reference from wallabag: store the API token and adding a key in extension options to renew the token periodically.

@jacksonh
Copy link
Contributor

Fix here, not published yet, need to do a bit more testing with other features like PDF handling: #2210

@jacksonh
Copy link
Contributor

Submitted to the Firefox extension store.

@jacksonh
Copy link
Contributor

ok, this is available as 2.0.4 in the add-ons store. Here is a quick demo:

https://www.loom.com/share/8d47fecd6454431b96e074dbea2fd8a6

@jacksonh jacksonh closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants