Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nested structured config validation #1133

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: Nested structured config validation #1133

wants to merge 10 commits into from

Commits on Oct 20, 2023

  1. First try at fixing dict[..., dict[..., StructuredConfig]].

    @bzczb
    bzczb committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f40738d View commit details
    Browse the repository at this point in the history

  2. Forgot to import ListConfig. test_nested_containers.py::test_merge_ba… 

    …d_element type still fails but I don't have time to fix it.
    @bzczb
    bzczb committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    87606cf View commit details
    Browse the repository at this point in the history

  3. typo

    @bzczb
    bzczb committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e5d8a20 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Explicitly set key_type and element_type for nested map merge. 

    First try to fix nested list merge.
    @bzczb
    bzczb committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    54d515f View commit details
    Browse the repository at this point in the history

  2. Missed the ListMergeMode.

    @bzczb
    bzczb committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    ca25af8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Fix error msg for one test; add tests for DeeplyNestedUser.

    @bzczb
    bzczb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    6961f47 View commit details
    Browse the repository at this point in the history

  2. Test even deeper nesting; add checks for key_type and element_type.

    @bzczb
    bzczb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    a45da17 View commit details
    Browse the repository at this point in the history

  3. standardize the quotes

    @bzczb
    bzczb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    598bace View commit details
    Browse the repository at this point in the history

  4. isort and black

    @bzczb
    bzczb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    81e826b View commit details
    Browse the repository at this point in the history

  5. test params readability

    @bzczb
    bzczb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    95a3f33 View commit details
    Browse the repository at this point in the history