“Land” field in onOffice enterprise is a single select but it is output as input field in plugin and frontend #540

fredericalpers · 2023-05-26T08:10:50Z

Discussed in #535

^{Originally posted by fredericalpers May 26, 2023}

Current state

The "Land" field is displayed as an input field in the plugin and in the frontend. However it is a single select in onOffice enterprise. This causes problems.

Forms can not be submitted if a country name like "France" is entered. It is only possible to sent a form when typing the value from onOffice enterprise "10" for France. If the input is 10 then the form is sent and also an address will be created.

If the fieldname "FRA" is entered, the form will be sent with "no data" to the e-mail but in onOffice enterprise the correct country will be added to the address.

Edit: deleted the investigation part

Desired state

In the plugin and in the frontend, the field must also be a single select. All countries that the customers have activated in onOffice enterprise should be selectable here.

yeneastgate · 2023-06-01T09:07:30Z

@fredericalpers
After checking this issue, we need more than a week to investigate closely and also work on it.
Meanwhile, some issues in the cycle 25/05 such as "Default values for estate list" and other issues in this cycle also account for a considerable amount of time.
Therefore, I'm not sure I'll be able to finish this issue in time this cycle. It would be great if we can push this issue to the next cycle so that we have enough time to work well on other issues.
At that time, we can deal with a small change issue, please check and push if necessary. Thanks.

fredericalpers · 2023-06-02T08:11:15Z

@fredericalpers After checking this issue, we need more than a week to investigate closely and also work on it. Meanwhile, some issues in the cycle 25/05 such as "Default values for estate list" and other issues in this cycle also account for a considerable amount of time. Therefore, I'm not sure I'll be able to finish this issue in time this cycle. It would be great if we can push this issue to the next cycle so that we have enough time to work well on other issues. At that time, we can deal with a small change issue, please check and push if necessary. Thanks.

Thank you for investigating. I will lock this issue and push it to the next cycle. :)

dai-eastgate · 2023-06-22T09:01:34Z

Hi @fredericalpers, I have a few questions that need your clarification:

Currently, I check the code and find there are 2 keys "land" and "Land", the one you are trying to change is "Land" right?
In the Investigate section, I understand your requirement but I don't really understand why you want to change the name from "Land" to "Country"
Do you want the "Land" field to be a single select in both frontend and backend?

fredericalpers · 2023-06-22T10:30:09Z

@dai-eastgate

we need to use both. "Land" is for address. "land" is for properties.
for instance: in the applicantform in the part for contact details (address) the field "Land" has to be used.
Further down in the part of the search criteria the "land" field has to be used.

In search forms also the "land" field has to be used.

We do not want to change the name to "country".
yes, please change the field to a single select in both frontend and backend.

dai-eastgate · 2023-06-23T03:03:46Z

@dai-eastgate

we need to use both. "Land" is for address. "land" is for properties.
for instance: in the applicantform in the part for contact details (address) the field "Land" has to be used.
Further down in the part of the search criteria the "land" field has to be used.

In search forms also the "land" field also the "land" field has to be used.

We do not want to change the name to "country".

yes, please change the field to a single select in both frontend and backend.

Yes, I will implement it. Thanks!

dai-eastgate · 2023-06-27T08:59:20Z

Apparently the "Land" field in the plugin is called "Country" everywhere. It is necessary to check whether a renaming in the plugin is necessary so that the function can be used as intended.

I have one question: If you don't want to change the name of "Land" to "Country", what do you mean, please explain to me.

fredericalpers · 2023-06-27T11:35:50Z

Apparently the "Land" field in the plugin is called "Country" everywhere. It is necessary to check whether a renaming in the plugin is necessary so that the function can be used as intended.

I have one question: If you don't want to change the name of "Land" to "Country", what do you mean, please explain to me.

@dai-eastgate you can ignore that part. I will edit it out of the original issue. :)

dai-eastgate · 2023-06-28T08:58:03Z

Hi @fredericalpers , I would like to confirm some points with you:

When I checked first, the "Land" field displays in the address as a single-select and the value option of the single-select is a number.
=> It leads to this issue: "Forms can not be submitted if a country name like "France" is entered. It is only possible to send a form when typing the value from onOffice enterprise "10" for France. If the input is 10 then the form is sent and also an address will be created."
Attached image
Currently, I check and see that the "Land" field displays in the address as single-select and the value option of single-select is "short name lower case"
Attached image

So, when we changed it to single-select, the address record is created correctly and the value of "Land" got the correct country submitted from the form.

However, another problem, that is: in the content of the email sent, the "Land" field did not display the value of the submitted country from the form.
Attached image

Reason: on your backend when generating email content, the "Land" field only accepts the value as "short name lowercase".
Please check it with your IT Department and let me know your opinions about this. Thanks!

fredericalpers · 2023-06-28T10:21:27Z

@dai-eastgate If I'm not confusing it myself right now, the field that is not displayed is the different "land" field. As mentioned in the comment above there are two different fields.

Can you confirm this?

yeneastgate · 2023-06-29T06:52:07Z

@fredericalpers
Sorry, You seem to be confusing "short name lowercase" in this comment "the 'Land' field only accepts the value as "short name lowercase".

"short name lowercase" is short name lowercase of ISO code
not mean is the "land" field.

We seem to find a solution for the "change the field 'Land' to a single select in both frontend and backend" issue work fine("Land" field display normal even in content email )
I need a day to research and implement it. I will reponse you later.

yeneastgate · 2023-06-29T09:25:31Z

@fredericalpers
I need onOffice API documentation for "do" action_id with "contactaddress" resourceType.

We don't find it in the API doc this link
https://apidoc.onoffice.de/
Please provide me as soon as possible, thanks

fredericalpers · 2023-06-29T12:07:27Z

@fredericalpers I need onOffice API documentation for "do" action_id with "contactaddress" resourceType.

We don't find it in the API doc this link https://apidoc.onoffice.de/ Please provide me as soon as possible, thanks

@yeneastgate I will get back to you as soon as possible, thank you. :)

fredericalpers · 2023-06-29T14:24:25Z

@yeneastgate please check the following links if any of this is helpful otherwise I will send a ticket to our IT-Department for clarification:

yeneastgate · 2023-07-03T10:44:52Z

I have researched, implemented and found the following problems:

When creating a contact address record
According to the "API doc", the field "Land" required data type as "STRING” and the value is "country as ISO 3166-1 alpha-3 value format"

But actually, if I submit the "Land" field as "ISO 3166-1 alpha-3 value", I can create a contact address record on the enterprise according to the name of the country we submitted, but the mail does not show that field.

cmt.mp4

If I send the “Land” field as "the German-translated country name", then I can create address in both contact and email

With the API doc you send me:
ApiResponseDoContactaddress(https://github.com/onOffice-Web-Org/oo-wp-plugin/blob/7a436759c3b386a27744cc67924ed6d57a73eb0a/tests/resources/ApiResponseDoContactaddress.json)
I can't find anything related to 'Land'.

So I guess, the current reason is that when generating email content, the "Land" field shows only "the German-translated country name".
For the input field value "FRA", the form will be sent with "no data" to the e-mail but in onOffice enterprise, the correct country will be added to the address.

Please check with your IT about these problems and let us know about your opinion. Thanks.

fredericalpers · 2023-07-07T11:08:23Z

postponed for now, since I'm still waiting for more information.

fredericalpers · 2023-09-05T09:41:42Z

We would like to split this issue into two issues. Before we do that we would like to confirm if the following is possible:

Since there is a problem with using ISO 3166-1 alpha-3 for the mail transmission, we would like to skip this and instead just transmit the value (e.g. 10 for france) in the mail for now. Would this be possible?

@yeneastgate

yeneastgate · 2023-09-05T09:50:30Z

@fredericalpers Yes, let me try again and report back to you with the clearest results

fredericalpers · 2023-09-18T10:34:32Z

@yeneastgate

(1) What is the GET request to get all available countries for address records?

https://apidoc.onoffice.de/actions/datensatz-anlegen/adressen/

The following request can be used to display the values for the "Land" field:

{
        "actionid":"urn:onoffice-de-ns:smart:2.5:smartml:action:get",
        "resourceid":"fieldvalues",
        "identifier":"",
        "resourcetype":"confignewaddressfields",
        "parameters":
        {
          "fieldname": "Land"
        }
}

(2) How do we have to write a post request to create an address record with a country?

https://apidoc.onoffice.de/actions/datensatz-anlegen/adressen/

For country, simply enter the ISO 3166-1 alpha-3 value such as "DEU" for Deutschland or "AUT" for Austria.

{
    "actionid":"urn:onoffice-de-ns:smart:2.5:smartml:action:create",
    "resourcetype":"address",
    "resourceid":"",
    "identifier":"",
    "parameters": {
        "Land":"AUT",
        "Vorname":"Max",
        "Name":"Mustermann"
    }
}

yeneastgate · 2023-09-19T00:44:05Z

@yeneastgate
Thanks, I will check and let you know asap.

yeneastgate · 2023-09-19T10:02:04Z

The following request can be used to display the values for the "Land" field:

{
        "actionid":"urn:onoffice-de-ns:smart:2.5:smartml:action:get",
        "resourceid":"fieldvalues",
        "identifier":"",
        "resourcetype":"confignewaddressfields",
        "parameters":
        {
          "fieldname": "Land"
        }
}

@fredericalpers yes, I can display the values for the "Land" field When calling this API

yeneastgate · 2023-09-19T10:03:12Z

https://apidoc.onoffice.de/actions/datensatz-anlegen/adressen/

For country, simply enter the ISO 3166-1 alpha-3 value such as "DEU" for Deutschland or "AUT" for Austria.
{
    "actionid":"urn:onoffice-de-ns:smart:2.5:smartml:action:create",
    "resourcetype":"address",
    "resourceid":"",
    "identifier":"",
    "parameters": {
        "Land":"AUT",
        "Vorname":"Max",
        "Name":"Mustermann"
    }
}

@fredericalpers I created an address record with a country When entering the ISO 3166-1 alpha-3 value such as "DEU" for Deutschland

yeneastgate · 2023-09-19T10:09:21Z

@fredericalpers However, when I enter the ISO 3166-1 alpha-3 value such as "DEU" for Deutschland, the "Land" Field do not show the value in the email content.

The reason is that this API is not working properly

ex: You can check this API on "sendEmail" function in file "FormPostInterest.php"
The API has parameters

ACTION_ID_DO = 'urn:onoffice-de-ns:smart:2.5:smartml:action:do';
resourceType: contactaddress

ex: I enter the ISO 3166-1 alpha-3 value such as "DEU" for Deutschland
$addressData for the "Land" field was submitted correctly is "DEU"

Please check the above API operation with the IT department and let me know the results.

fredericalpers · 2023-09-26T11:08:48Z

@yeneastgate as mentioned in this comment when using the german names of the countries everything works fine.

For that reason we want to investigate further but could not find how the plugin is "building" the email content. would you please be so kind and let us know where we can find how the plugin is "building" the email?

yeneastgate · 2023-09-27T02:53:12Z

@fredericalpers I will check and let you know asap.

yeneastgate · 2023-09-27T06:58:17Z

where we can find how the plugin is "building" the email?
@fredericalpers
You can check this API on "sendEmail" function in file "FormPostContact.php".

oo-wp-plugin/plugin/FormPostContact.php

Line 170 in 54921f8

private function sendContactRequest(FormData $pFormData, string $recipient = '', $subject = null)

fredericalpers · 2023-09-28T07:11:15Z

@yeneastgate

As mentioned in this comment from september 6, more specifically

Entering the correct value e.g. "Deutschland" will correctly transmit the data to onOffice enterprise and also will correctly display it as "Land: Deutschland" in the e-mail.

Please implement a singleselect for both backend and frontend that's displaying the german full name of the countries such as Deutschland, Frankreich, Spanien etc. that are available in onOffice enterprise.

Also use this full name to transfer the data into onOffice enterprise and via email.

yeneastgate · 2023-09-28T09:58:49Z

@fredericalpers Ok, I will check

yeneastgate · 2023-10-02T11:13:42Z

@fredericalpers
I tried using a few libraries(e.g.: League..) to get "the German full name of the countries" from "ISO 3166-1 alpha-3 code"
However, the name of the countries returned is not the same name displayed on the enterprise.

=> So please update the API response "https://apidoc.onoffice.de/actions/datensatz-anlegen/adressen/" return "the German full name of the countries" information.
ex:
{
"id": "VIR",
"type": "",
"elements": {
"title": "American Virgin Islands"
"name": "the German full name of the countries"
}
},

fredericalpers · 2023-11-13T09:14:33Z

@yeneastgate https://apidoc.onoffice.de/actions/informationen-abfragen/single-and-multiselect-values/

shouldn't it be possible to display the german full name using the "title" of the response? The value of "title" should also be the one being displayed in the e-mail. In the attached XML however it should still use the corresponding ISO 3166-1 alpha-3, so onOffice enterprise can correctly interpret the value.

yeneastgate · 2023-12-29T03:53:43Z

@fredericalpers After researching again I found that:
1.

shouldn't it be possible to display the german full name using the "title" of the response? The value of "title" should also be the one being displayed in the e-mail.

=> Yes, it is impossible to display the German full name using the "title" of the response When using the "contactaddress" API to send the email.

I also tried implementing testing on branch "35108-implement-change-land-field-input-to-single-select"

Step 1: Generate the "email body content" on the "onoffice wordpress plugin" side with the "sendmail" old API.
Step 2: Processed the "addressData" with the "createStringFromInputData" method before passing it to $requestParams($body)
=> It is possible to display the German full name using the "title" of the response.

540_cmt.mp4

So I think:
We missed process the "addressData" when generating the "content body of email" using the "contactaddress" API of the Onoffice Enterprise system.
=>If we process the "addressData" => Possibly display the full German name using the "title" field when sending an email using the "contactaddress" API.
=> Please check with the IT department again.

In the attached XML however it should still use the corresponding ISO 3166-1 alpha-3, so onOffice enterprise can correctly interpret the value.

I checked again and I did not find <land></land> XML tags related to data processing for the "Land" field (even though I entered a value for the "Land" field when submitting the form).

=> Please check with the IT department generated miss <land></land> XML tags When using the "contactaddress" API to send emails has attachment XML.

fredericalpers · 2024-01-10T10:48:45Z

@yeneastgate

Step 1: Generate the "email body content" on the "onoffice wordpress plugin" side with the "sendmail" old API.
Step 2: Processed the "addressData" with the "createStringFromInputData" method before passing it to $requestParams($body)
=> It is possible to display the German full name using the "title" of the response.

When using this, the transmission in the mail works as intended, correct?

The XML-Tag seems not to be necessary. It's currently not in the feedback.xml file which is attached to the email but the countries are transmitted to onOffice enterprise correctly.

nglelinh · 2024-01-11T10:53:17Z

@fredericalpers your last response is a little bit confusing for us. Let me try to summarize our understanding, please help to confirm

the issue is missing a "Land" field in the email sending to the user
current implementation uses the API endpoint - "contactaddress", which generates the email, but the logic on enterprise side misses "Land" field, and we can not control that to add the "Land field
using the another API - "sendemail", we can generate the email content on the plugin side and add the missing "Land" field, but the plugin can not generate the .xml file

Question:

what should we investigate more ?

If needed we can schedule a call to take about

fredericalpers added bug Indicates an unexpected problem or unintended behaviour investigate labels May 26, 2023

fredericalpers added 3 weeks and removed investigate labels Jun 2, 2023

onOffice-Web-Org locked and limited conversation to collaborators Jun 2, 2023

onOffice-Web added this to the v4.13 milestone Jun 7, 2023

onOffice-Web added 3 weeks and removed 3 weeks labels Jun 7, 2023

onOffice-Web-Org unlocked this conversation Jun 20, 2023

fredericalpers added the blocked Blocked due to external factors label Jul 7, 2023

fredericalpers modified the milestones: v4.14, v4.16 Jul 7, 2023

fredericalpers removed this from the v4.16 milestone Aug 9, 2023

fredericalpers removed the blocked Blocked due to external factors label Sep 18, 2023

fredericalpers added this to the v4.17 milestone Sep 18, 2023

fredericalpers mentioned this issue Sep 27, 2023

Custom label for "Land" and "land" field #644

Closed

fredericalpers modified the milestones: v4.17, v4.18 Oct 12, 2023

fredericalpers added the up for discussion Issues and Pull Requests which will be discussed label Oct 12, 2023

fredericalpers removed this from the v4.18 milestone Oct 25, 2023

yeneastgate self-assigned this Oct 31, 2023

fredericalpers added this to the v4.19 milestone Nov 13, 2023

fredericalpers added investigate and removed up for discussion Issues and Pull Requests which will be discussed labels Nov 13, 2023

fredericalpers removed this from the v4.19 milestone Jan 8, 2024

fredericalpers added blocked Blocked due to external factors and removed investigate 3 weeks labels Feb 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

“Land” field in onOffice enterprise is a single select but it is output as input field in plugin and frontend #540

“Land” field in onOffice enterprise is a single select but it is output as input field in plugin and frontend #540

fredericalpers commented May 26, 2023 •

edited

Loading

Current state

Desired state

yeneastgate commented Jun 1, 2023

fredericalpers commented Jun 2, 2023

dai-eastgate commented Jun 22, 2023 •

edited

Loading

fredericalpers commented Jun 22, 2023 •

edited

Loading

dai-eastgate commented Jun 23, 2023

dai-eastgate commented Jun 27, 2023

fredericalpers commented Jun 27, 2023

dai-eastgate commented Jun 28, 2023 •

edited

Loading

fredericalpers commented Jun 28, 2023

yeneastgate commented Jun 29, 2023 •

edited

Loading

yeneastgate commented Jun 29, 2023

fredericalpers commented Jun 29, 2023

fredericalpers commented Jun 29, 2023

yeneastgate commented Jul 3, 2023

fredericalpers commented Jul 7, 2023

fredericalpers commented Sep 5, 2023

yeneastgate commented Sep 5, 2023

fredericalpers commented Sep 18, 2023

yeneastgate commented Sep 19, 2023

yeneastgate commented Sep 19, 2023 •

edited

Loading

yeneastgate commented Sep 19, 2023 •

edited

Loading

yeneastgate commented Sep 19, 2023 •

edited

Loading

fredericalpers commented Sep 26, 2023

yeneastgate commented Sep 27, 2023

yeneastgate commented Sep 27, 2023 •

edited

Loading

fredericalpers commented Sep 28, 2023

yeneastgate commented Sep 28, 2023

yeneastgate commented Oct 2, 2023 •

edited

Loading

fredericalpers commented Nov 13, 2023

yeneastgate commented Dec 29, 2023 •

edited

Loading

fredericalpers commented Jan 10, 2024

nglelinh commented Jan 11, 2024

“Land” field in onOffice enterprise is a single select but it is output as input field in plugin and frontend #540

“Land” field in onOffice enterprise is a single select but it is output as input field in plugin and frontend #540

Comments

fredericalpers commented May 26, 2023 • edited Loading

Discussed in #535

Current state

Desired state

yeneastgate commented Jun 1, 2023

fredericalpers commented Jun 2, 2023

dai-eastgate commented Jun 22, 2023 • edited Loading

fredericalpers commented Jun 22, 2023 • edited Loading

dai-eastgate commented Jun 23, 2023

dai-eastgate commented Jun 27, 2023

fredericalpers commented Jun 27, 2023

dai-eastgate commented Jun 28, 2023 • edited Loading

fredericalpers commented Jun 28, 2023

yeneastgate commented Jun 29, 2023 • edited Loading

yeneastgate commented Jun 29, 2023

fredericalpers commented Jun 29, 2023

fredericalpers commented Jun 29, 2023

yeneastgate commented Jul 3, 2023

fredericalpers commented Jul 7, 2023

fredericalpers commented Sep 5, 2023

yeneastgate commented Sep 5, 2023

fredericalpers commented Sep 18, 2023

(1) What is the GET request to get all available countries for address records?

(2) How do we have to write a post request to create an address record with a country?

yeneastgate commented Sep 19, 2023

yeneastgate commented Sep 19, 2023 • edited Loading

yeneastgate commented Sep 19, 2023 • edited Loading

yeneastgate commented Sep 19, 2023 • edited Loading

fredericalpers commented Sep 26, 2023

yeneastgate commented Sep 27, 2023

yeneastgate commented Sep 27, 2023 • edited Loading

fredericalpers commented Sep 28, 2023

yeneastgate commented Sep 28, 2023

yeneastgate commented Oct 2, 2023 • edited Loading

fredericalpers commented Nov 13, 2023

yeneastgate commented Dec 29, 2023 • edited Loading

fredericalpers commented Jan 10, 2024

nglelinh commented Jan 11, 2024

fredericalpers commented May 26, 2023 •

edited

Loading

dai-eastgate commented Jun 22, 2023 •

edited

Loading

fredericalpers commented Jun 22, 2023 •

edited

Loading

dai-eastgate commented Jun 28, 2023 •

edited

Loading

yeneastgate commented Jun 29, 2023 •

edited

Loading

yeneastgate commented Sep 19, 2023 •

edited

Loading

yeneastgate commented Sep 19, 2023 •

edited

Loading

yeneastgate commented Sep 19, 2023 •

edited

Loading

yeneastgate commented Sep 27, 2023 •

edited

Loading

yeneastgate commented Oct 2, 2023 •

edited

Loading

yeneastgate commented Dec 29, 2023 •

edited

Loading