Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onoffice-style.css with child theme #548

Closed
onOffice-Web opened this issue Jun 7, 2023 Discussed in #533 · 2 comments · Fixed by #592
Closed

onoffice-style.css with child theme #548

onOffice-Web opened this issue Jun 7, 2023 Discussed in #533 · 2 comments · Fixed by #592
Labels
QA Issue or Pull request that is in review
Milestone

Comments

@onOffice-Web
Copy link
Collaborator

Discussed in #533

Originally posted by fredericalpers May 26, 2023

Current state

The onoffice-style.css does not work properly when using a child theme. The plugin recognizes that the file is in the child theme, but then includes it with the URL of the parent theme.

Desired state

The URL must be adjusted so that the onoffice-style.css are recognized and included correctly in any possible case.

@yeneastgate
Copy link
Contributor

Hi @fredericalpers,
I fixed this issue, please take a look at my attached video and let me know your opinion about this. Thanks!
https://files.fm/f/qpudq94ta

@onOffice-Web
Copy link
Collaborator Author

@yeneastgate Looks good to me! Thank you :)

@onOffice-Web onOffice-Web added QA Issue or Pull request that is in review and removed 1 week labels Jul 12, 2023
@fredericalpers fredericalpers linked a pull request Jul 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants