Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort property lists #549

Closed
onOffice-Web opened this issue Jun 7, 2023 Discussed in #507 · 4 comments · Fixed by #586
Closed

Sort property lists #549

onOffice-Web opened this issue Jun 7, 2023 Discussed in #507 · 4 comments · Fixed by #586
Labels
documentation Indicates the need for improvements or additions to the documentation feature New feature QA Issue or Pull request that is in review
Milestone

Comments

@onOffice-Web
Copy link
Collaborator

Discussed in #507

Originally posted by fredericalpers April 25, 2023

Current state

At the moment the created property lists can not be sorted. With a large number of lists, it is difficult to find the correct one.

Desired state

The ones marked in the screenshot should be sortable, like in the WP page overview. Sorting for "Name of list", "Selected filter", "Template" and "List type".

sort-property-lists

@onOffice-Web onOffice-Web added this to the v4.14 milestone Jun 7, 2023
@dai-eastgate
Copy link
Contributor

@fredericalpers Currently, the 4 fields you want to be sorted, must be sorted by the value in the database.
I checked in the code and found that 3 fields: "Name of the list", "Template" and "List type" can be sorted normally because in the database it is stored as a name. But the "Selected filter" field is stored as an id in the database while the plugin has displayed that field as a name.
Therefore, I can only sort this "Selected filter" field by id.
Please let me know your opinion about this. Thanks.

@fredericalpers
Copy link
Member

fredericalpers commented Jun 22, 2023

Please go ahead and first implement the 3 fields "Name of the list", "Template" and "List type".

For the "selected filter" we will have to discuss it internally again. Thank you.

edit: what is your time estimate on this?

@dai-eastgate
Copy link
Contributor

Please go ahead and first implement the 3 fields "Name of the list", "Template" and "List type".

For the "selected filter" we will have to discuss it internally again. Thank you.

edit: what is your time estimate on this?

I need 3 days to implement the sort of 3 fields "Name of the list", "Template" and "List type".

@fredericalpers fredericalpers added QA Issue or Pull request that is in review feature New feature and removed 1 week labels Jul 4, 2023
@dai-eastgate
Copy link
Contributor

@fredericalpers I have implemented the sort feature for these 3 fields: "Name of the list", "Template" and "List type". Please take a look at my video and let me know your opinion. Thanks!

36779.mp4

@onOffice-Web onOffice-Web added the documentation Indicates the need for improvements or additions to the documentation label Jul 12, 2023
@fredericalpers fredericalpers linked a pull request Jul 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Indicates the need for improvements or additions to the documentation feature New feature QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants