Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Download in property lists #590

Closed
fredericalpers opened this issue Jul 7, 2023 · 8 comments · Fixed by #599
Closed

PDF Download in property lists #590

fredericalpers opened this issue Jul 7, 2023 · 8 comments · Fixed by #599
Assignees
Labels
component: dashboard Issue, Pull Request or Discussion related to dashboard / settings page component: property list Issue, Pull Request or Discussion related to property lists QA Issue or Pull request that is in review
Milestone

Comments

@fredericalpers
Copy link
Member

Current state

Currently it is possible to set a pdf download for the property list. See attached screenshot. This function does not work and should not exist in the property lists.

Desired state

It has to be removed from property lists and should only be available in detail pages.

property-list-pdf

@fredericalpers fredericalpers added this to the v4.14 milestone Jul 7, 2023
@fredericalpers
Copy link
Member Author

@dai-eastgate @yeneastgate please let me know if this will still fit in the current cycle/milestone or if I should move it to v4.16

@dai-eastgate
Copy link
Contributor

It has to be removed from property lists and should only be available in detail pages.

I will check and let you know as soon as possible

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Jul 13, 2023

Hi, @fredericalpers. After checking I found the following:

  1. "PDF download" feature exists in 3 positions: Estate List, Detail View, and Unit Lists.
  • Current State:
    + Detail View: work normal
    + Estate List And Unit Lists: do not work
    => Do you want me to remove the "PDF Download" feature in Estate List only or do you want to delete the unit list as well?
  1. I set the shortcode of the unit list as this document (https://wp-plugin.onoffice.com/en/advanced-features/unit-lists/) and found it is working the same as the detail view (The fields displayed on the "Units" page are the fields configured in the "detail view").
    image
    But if I put the shortcode like "[oo_estate units="Units" view="Units"], the "Units" Page displays in front-end:
    image
    => If possible please provide me a video on how to use "unit lists" so I can test it

@onOffice-Web
Copy link
Collaborator

@dai-eastgate Unit lists are currently a little confusing to use. They are just a addition to the detail page. We are already working on how to better implement them. More about that in the future.

Please remove it from both the property list, as well as the unit list. Thank you. :)

@dai-eastgate
Copy link
Contributor

@dai-eastgate Unit lists are currently a little confusing to use. They are just a addition to the detail page. We are already working on how to better implement them. More about that in the future.

Please remove it from both the property list, as well as the unit list. Thank you. :)

I need 2 days to implement and test it. Thanks!

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Jul 17, 2023

@fredericalpers For this issue, we would like to move it to the next cycle, as we are completing two issues: 553 & 562. Thanks!

@onOffice-Web onOffice-Web modified the milestones: v4.14, v4.15 Jul 17, 2023
@fredericalpers fredericalpers linked a pull request Jul 31, 2023 that will close this issue
@yeneastgate
Copy link
Contributor

Hi, @fredericalpers I finished implementing and testing this issue. Please take a look at my attached video and let me know your opinion. Thanks!

pdf.4.mp4

@fredericalpers
Copy link
Member Author

@yeneastgate looks good to me, thank you :)

@fredericalpers fredericalpers added QA Issue or Pull request that is in review and removed 1 week labels Aug 1, 2023
@fredericalpers fredericalpers removed this from the v4.15 milestone Sep 28, 2023
@fredericalpers fredericalpers added the up for discussion Issues and Pull Requests which will be discussed label Sep 28, 2023
@yeneastgate yeneastgate self-assigned this Oct 31, 2023
@fredericalpers fredericalpers removed the up for discussion Issues and Pull Requests which will be discussed label Nov 13, 2023
@fredericalpers fredericalpers modified the milestone: v4.16 Nov 13, 2023
@fredericalpers fredericalpers added the up for discussion Issues and Pull Requests which will be discussed label Nov 14, 2023
@fredericalpers fredericalpers added this to the v5.1 milestone Jul 29, 2024
@fredericalpers fredericalpers added component: property list Issue, Pull Request or Discussion related to property lists component: dashboard Issue, Pull Request or Discussion related to dashboard / settings page and removed up for discussion Issues and Pull Requests which will be discussed labels Jul 29, 2024
@andernath andernath modified the milestones: v5.1, v5.0 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard Issue, Pull Request or Discussion related to dashboard / settings page component: property list Issue, Pull Request or Discussion related to property lists QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants