Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field types #634

Closed
fredericalpers opened this issue Sep 18, 2023 · 12 comments · Fixed by #653
Closed

Missing field types #634

fredericalpers opened this issue Sep 18, 2023 · 12 comments · Fixed by #653
Assignees
Labels
QA Issue or Pull request that is in review
Milestone

Comments

@fredericalpers
Copy link
Member

Regarding Issue 557.

"Some fields are not displayed in the correct format "default value" feature for that field type. The reason is that the "field type" API result responses of these fields are not covered in the source code. These are the fields whose type is not covered in the code. Please check the file listed by name and type as follows.."

Current state

The following field keys & types are missing as mentioed in the issue above:

  • bisdatum ➤ urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:date
  • balkon ➤ urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:tinyint
  • benutzer ➤ urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:User
  • Kundenlogo ➤ blob
  • placeholderEnergy ➤ urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:BlackHint

Desired state

The following field keys & types should be added to the code:

  • bisdatum ➤ urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:date
  • balkon ➤ urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:tinyint
  • benutzer ➤ urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:User (the frontend has to be a single select not a input field)

The field keys & types do not have to be added:

  • Kundenlogo since it is not possible to transfer/send images to onOffice enterprise with the API.
  • placeholderEnergy --> urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:BlackHint
@yeneastgate
Copy link
Contributor

yeneastgate commented Sep 25, 2023

@fredericalpers

  1. For "urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:date" type fields:
  • We must submit "value for these fields" as "DateTime" format to create the correct data in Enterprise.
    example: "yy/mm/dd", "yy-mm-dd" or "yy.mm.dd"
  • In the master branch, these fields display in both the front-end and back-end as image below:
    image
    => Would you like to keep this format or use a "Datepicker" format as shown in the image below?
    image
  1. For "urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:tinyint" type fields:
  • We must submit "value for these fields" as "boolean" format
    example: "0" corresponds to "No" or "1" corresponds to "Yes"
cmt.missing.field.mp4
  • In the master branch, these fields display in the front-end and back-end as image below
    image

=> Would you like to display them in a "BOOLEAN" format as shown in the image?
image

@fredericalpers
Copy link
Member Author

fredericalpers commented Sep 25, 2023

@yeneastgate I will be able to give you feedback on this tomorrow, thank you :)

@fredericalpers
Copy link
Member Author

@yeneastgate As for no.1 please implement the suggested date picker. Make sure it has a good usability on mobile devices and it works in all browsers. E.g. Chrome, Firefox, Safari etc.

As for no.2 is it possible to use radio buttons instead of a select? This way we can show both possible values and its easier to change for customers.

@yeneastgate
Copy link
Contributor

@fredericalpers I will try implementing it and will update the results for you ASAP.

@yeneastgate
Copy link
Contributor

yeneastgate commented Oct 2, 2023

As for no.1 please implement the suggested date picker. Make sure it has a good usability on mobile devices and it works in all browsers. E.g. Chrome, Firefox, Safari etc.

@fredericalpers The "date picker" feature has been already implemented in the Estate List. I tested and it works fine.
Mobile devices:
iPhone 13 (1170 x 2532)
iPhone 7 (750 x 1334)
iPhone 6 (750 x 1334)
iPhone XR (414x 896)
Ipad Gen 7 (2160 x 1620)
Realme 11 Pro (1080 x 2412)

iPhone6_IOS_Safari_Version_12.5.7.mov
iPhone13.mov

Browsers:
Chrome: version 117, 107
Edge: version 117, 107
Opera: version 102, 98
Safari: 16.5.1

Recording.79.mp4
edge_version117.mp4

Do you want me to test it on any other specific browsers or mobile versions?

@yeneastgate
Copy link
Contributor

yeneastgate commented Oct 2, 2023

@fredericalpers

  1. If there's no need for further testing, I will implement the 'date picker' feature similar to the one in the Estate List
  2. .This is the list of fields that will be implemented.

list-fields
=> It will take 6 days to implement and test it. Thanks!

@fredericalpers
Copy link
Member Author

@yeneastgate please go ahead and implement the date picker and the missing field list, thank you :)

@yeneastgate
Copy link
Contributor

@yeneastgate please go ahead and implement the date picker and the missing field list, thank you :)

OK. I will implement it.

@yeneastgate
Copy link
Contributor

yeneastgate commented Oct 3, 2023

@fredericalpers I checked and found that:
To change from "input text" to "date picker" and type "tinyInt" to "radio button".
image
image
=> Can I edit the "fields.php" file?

@fredericalpers
Copy link
Member Author

@yeneastgate please go ahead :)

@yeneastgate
Copy link
Contributor

yeneastgate commented Oct 9, 2023

@fredericalpers
Currently, in the form, I see fields with the "Date" or "DateTime" type Which display as "text field"

image
image

=> Please confirm:
Do you need to change those types "text field" to "Date picker"?
image

@yeneastgate
Copy link
Contributor

yeneastgate commented Oct 10, 2023

@fredericalpers
I have added types for the missing fields:

  • urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:date ("input text" => "date picker")
  • urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:tinyint ("input text" => "radio button")
  • urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:User ("input text" => "single select")

Please watch my video demo and let me know your opinion. Thanks!
https://files.fm/u/u7puprntxt

@fredericalpers fredericalpers linked a pull request Oct 12, 2023 that will close this issue
@fredericalpers fredericalpers added QA Issue or Pull request that is in review and removed 1 week labels Oct 12, 2023
@yeneastgate yeneastgate self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants