Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom label for "Land" and "land" field #644

Closed
fredericalpers opened this issue Sep 27, 2023 · 3 comments · Fixed by #662
Closed

Custom label for "Land" and "land" field #644

fredericalpers opened this issue Sep 27, 2023 · 3 comments · Fixed by #662
Assignees
@yeneastgate
Labels
QA Issue or Pull request that is in review
Milestone
v4.18

Comments

@fredericalpers
Copy link
Member

Current state

While further investigating the current Issue

we realized that the custom labels do not work as intended. The custom label seem to overwrite each other. Possibly because the field names are not case-sensitive? In the frontend however the opposite value will be displayed. Please see the screenshot attached.

custom-label-land

Desired state

The custom labels for both fields should work correctly and not overwrite each other.
@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour small change A change that is small that can be dealt with during ramp-up. investigate labels Sep 27, 2023
@fredericalpers fredericalpers added this to the v4.18 milestone Sep 27, 2023
@yeneastgate
Copy link
Contributor

@fredericalpers I will implement it. Thanks!

@yeneastgate yeneastgate self-assigned this Oct 25, 2023
@yeneastgate yeneastgate mentioned this issue Oct 26, 2023
Merged
@yeneastgate
Copy link
Contributor

@fredericalpers I fixed this bug. Please watch my video demo and let me know your opinions. Thanks!

https://files.fm/f/qpvapqtgef

@fredericalpers
Copy link
Member Author

@yeneastgate seems to be working fine now, thank you :)

@fredericalpers fredericalpers linked a pull request Oct 31, 2023 that will close this issue
41619 Custom label for "Land" and "land" field #662
Merged
@fredericalpers fredericalpers added QA Issue or Pull request that is in review and removed bug Indicates an unexpected problem or unintended behaviour small change A change that is small that can be dealt with during ramp-up. investigate labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeneastgate yeneastgate

Labels
QA Issue or Pull request that is in review
Projects
None yet
Milestone
v4.18
Development

Successfully merging a pull request may close this issue.

41619 Custom label for "Land" and "land" field onOffice-Web-Org/oo-wp-plugin
2 participants
@fredericalpers @yeneastgate