Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cache with admin bar quick action on multisites #661

Closed
fredericalpers opened this issue Oct 25, 2023 · 5 comments · Fixed by #682
Closed

Clear cache with admin bar quick action on multisites #661

fredericalpers opened this issue Oct 25, 2023 · 5 comments · Fixed by #682
Assignees
Labels
QA Issue or Pull request that is in review
Milestone

Comments

@fredericalpers
Copy link
Member

fredericalpers commented Oct 25, 2023

Current State

With multisites, the cache cannot be cleared with the quick action "Clear cache" in the admin bar. It'll lead to a URL like: https://multisite-domain/wp-admin/onoffice-clear-cache which causes an error as seen below.

Not Found
The requested URL was not found on this server.

Desired State

The quick action "Clear cache" should also work for multisites.

@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour investigate labels Oct 25, 2023
@fredericalpers fredericalpers added this to the v4.19 milestone Nov 8, 2023
@dai-eastgate
Copy link
Contributor

@fredericalpers For this issue, I am working on it and will get back to you soon.

@yeneastgate
Copy link
Contributor

yeneastgate commented Nov 21, 2023

@fredericalpers I fixed this bug. Please watch my video test on WordPress Multisite and let me know your opinion. Thanks!
This feature still works fine on multisites.
https://files.fm/u/5r9q3mz5tz#/view/893bvprrdy

Note: This feature still works fine on single-site.
https://files.fm/f/3rmacn26jw

@fredericalpers
Copy link
Member Author

@yeneastgate looks good to me, is there anyway you can also test this on an actual WordPress Multisite or am I missing something?

@yeneastgate
Copy link
Contributor

yeneastgate commented Nov 22, 2023

@fredericalpers I fixed this bug. Please watch my video test on WordPress Multisite and let me know your opinion. Thanks!
This feature still works fine on multisites.
https://files.fm/u/5r9q3mz5tz#/view/893bvprrdy

@fredericalpers there anyway I can also test this on an actual WordPress Multisite

@fredericalpers
Copy link
Member Author

fredericalpers commented Nov 22, 2023

@yeneastgate I'm blind, sorry :D thank you for the quick fix.

Edit: Moved this to 4.16 for the review and being able to release it soon.

@fredericalpers fredericalpers modified the milestones: v4.19, v4.16 Nov 22, 2023
@fredericalpers fredericalpers added QA Issue or Pull request that is in review and removed bug Indicates an unexpected problem or unintended behaviour investigate labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants