Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form can not be sent with unfilled required fields and enabled recaptcha #669

Closed
andernath opened this issue Nov 6, 2023 · 3 comments · Fixed by #671
Closed

Form can not be sent with unfilled required fields and enabled recaptcha #669

andernath opened this issue Nov 6, 2023 · 3 comments · Fixed by #671
Assignees
Labels
QA Issue or Pull request that is in review
Milestone

Comments

@andernath
Copy link
Contributor

While testing #648 I have found 2 bugs in forms that have required fields and use reCAPTCHA.

Major bug 1:

Form can not be sent. See Picture 03.
To reproduce the bug:

  • open a form with required field and enabled recapcha
  • just send form (WITHOUT touching any input fields)

Now the sending button turn disbaled because you did not fill all required fields, but no hint will be shown. There is no way to enable the sending button again.

Minor bug 2:

Styling of required field hint is wrong. Picture 02.
To reproduce the bug:

  • open a form with required field and enabled recapcha
  • click inside an input field without filling it
  • send form

Hint will be displayed but not with the same text and style like Picture 01.


Picture 01 (Hint if no recapcha is enabled and user did not fill required field)
01_required_hint
Picture 02
02_required_hint_with_recapcha
Picture 03
03_required_hint_recapcha_not_loaded

@dai-eastgate
Copy link
Contributor

@andernath I will check and let you know asap. Thanks!

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Nov 7, 2023

@fredericalpers @andernath

Major bug 1:

I have fixed this bug. Please watch my video demo

bug1.mp4

Minor bug 2:

I have fixed this bug. Please watch my video demo

bug2.mp4

Note: I have implemented "reCAPTCHA correctly for each form" to follow in this linked document (https://developers.google.com/recaptcha/docs/display#explicit_render)

@andernath
Copy link
Contributor Author

Good work @dai-eastgate
I will review and test ist later.

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Issue or Pull request that is in review
Projects
None yet
3 participants