Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings pages Property list loading time #700

Closed
4 tasks done
fredericalpers opened this issue Dec 7, 2023 · 5 comments · Fixed by #712
Closed
4 tasks done

Settings pages Property list loading time #700

fredericalpers opened this issue Dec 7, 2023 · 5 comments · Fixed by #712
Assignees
Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page performance Issue, Pull Request or Discussion related to performance QA Issue or Pull request that is in review
Milestone

Comments

@fredericalpers
Copy link
Member

fredericalpers commented Dec 7, 2023

Initiative

Improve the onOffice for WP-Websites plugin for a better user experience.

Epic

Analyze and improve the performance of the settings page for property lists in the plugin backend.

User Story

As a real estate agent relying on the onOffice for WP-Websites Plugin, I've noticed a significant layout shift in the backend, particularly on the property detail page setttings page. This shift appears to be linked to the "chosen" script. To enhance the backend display and eliminate layout shifts, I propose replacing the "chosing" script with the already implemented "select2" script.

This replacement aims to improve the overall stabiliy and responsivness of the backend.

Tasks

  • Identify the section of the property detail page settings page where the problems occur.
  • If possible replace the "chosen" script with the "select2" script, ensuring that the functionality remains consistent.
  • Verify that the "select" script seamlessly integrates with the existing functionality.
  • Conduct thorough testing to evaluate the layout stability.

By implementing these changes the onOffice for WP-Websites Plugin can offer real estate agents a more stable and responsive backend experience, particularly on the property detail page settings page.

@fredericalpers fredericalpers added this to the v4.20 milestone Dec 7, 2023
@dai-eastgate dai-eastgate self-assigned this Dec 14, 2023
@dai-eastgate
Copy link
Contributor

@fredericalpers

  • If possible replace the "chosen" script with the "select2" script, ensuring that the functionality remains consistent.

=>Currently, I check that the search feature when using the "chosen" script is still guaranteed when using "select2" according to the following list:
image
Please let me know your opinions. Thanks!

@fredericalpers
Copy link
Member Author

fredericalpers commented Dec 14, 2023

@dai-eastgate please go ahead and implement select2 instead of "chosen" :)

@dai-eastgate
Copy link
Contributor

@yeneastgate please go ahead and implement select2 instead of "chosen" :)

Thanks! I need 2 days to implement and test.

@yeneastgate
Copy link
Contributor

@fredericalpers Currently, the "chosen" script is only used in the ''edit list view'' screen.
=> I have replaced the ''chosen'' script with the ''select2'' script and the feature still works fine
image
Please take a look at my video demo and let me know your opinions. Thanks!

CMT_700.mp4

@dai-eastgate dai-eastgate removed their assignment Jan 4, 2024
@yeneastgate yeneastgate self-assigned this Jan 4, 2024
@fredericalpers
Copy link
Member Author

@yeneastgate looks good to me, thank you :)

@fredericalpers fredericalpers added QA Issue or Pull request that is in review and removed 1 week labels Jan 8, 2024
@fredericalpers fredericalpers linked a pull request Jan 8, 2024 that will close this issue
@fredericalpers fredericalpers added performance Issue, Pull Request or Discussion related to performance component: property detail page Issue, Pull Request or Discussion related to property detail page labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page performance Issue, Pull Request or Discussion related to performance QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants