P#56183 Optimize columns on list views for forms estates and addresses #139

tung-le-esg · 2021-11-17T09:23:59Z

P#56183 Optimize columns on list views for forms estates and addresses

…orms-estates-and-addresses

coveralls · 2021-12-20T03:15:58Z

Pull Request Test Coverage Report for Build 1964212787

37 of 110 (33.64%) changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 78.611%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
plugin/Record/RecordManagerReadListViewEstate.php	0	6	0.0%
plugin/Controller/DetailViewPostSaveController.php	32	99	32.32%

Files with Coverage Reduction	New Missed Lines	%
plugin/Controller/DetailViewPostSaveController.php	2	35.66%

Totals
Change from base Build 1962442938:	-0.1%
Covered Lines:	6123
Relevant Lines:	7789

💛 - Coveralls

jayay · 2021-12-22T16:45:36Z

tests/TestClassDatabaseChanges.php

@@ -213,7 +214,7 @@ public function testUninstall(array $createQueries)
 		// assert that as many tables have been removed as have been created
 		$uniqueCreateQueries = array_unique($createQueries);
 		$uniqueDropQueries = array_unique($this->_dropQueries);
-		$this->assertEquals(count($uniqueCreateQueries), count($uniqueDropQueries));
+		$this->assertGreaterThanOrEqual(count($uniqueCreateQueries), count($uniqueDropQueries));


How can more tables be dropped than created?

plugin/Controller/DetailViewPostSaveController.php

jayay · 2021-12-28T12:56:22Z

plugin/Controller/DetailViewPostSaveController.php

+			}
+			if (strpos($view->page_shortcode,(string)$postID)!== false)
+			{
+				$pageID = chop($view->page_shortcode,$postID);


This looks unstable. Better use explode, array functions. and implode.

jayay · 2021-12-28T12:57:09Z

plugin/Gui/Table/AddressListTable.php

@@ -144,7 +174,9 @@ public function prepare_items()
 		$columns = [
 			'cb' => '<input type="checkbox" />',
 			'name' => __('Name of View', 'onoffice-for-wp-websites'),
+			'template' => __('Tempaltes', 'onoffice-for-wp-websites'),


Typo in "Templates".

jayay · 2021-12-28T12:58:26Z

plugin/Gui/Table/EstateListTable.php

@@ -119,6 +124,31 @@ private function fillData()
 		]);
 	}

+	private function handleRecord($listRecord)


This block was duplicated so often. Can it be factored out into something reusable?

This is still open

jayay · 2021-12-28T12:58:40Z

plugin/Gui/Table/EstateListTable.php

+				$page = '';
+				foreach ($listPageID as $pageID)
+				{
+					if (!empty($page))


Better use implode.

this is still open, too

jayay · 2021-12-28T12:59:33Z

plugin/Gui/Table/EstateListTable.php

+					{
+						$page .= ',';
+					}
+					$page .= "<a href='".get_edit_post_link((int)$pageID)."' target='_blank'>".get_the_title((int)$pageID)."</a>";


esc_attr() missing around get_edit_post_link() and esc_html() missing around get_the_title.

jayay · 2021-12-28T13:00:20Z

plugin/Gui/Table/EstateListTable.php

+		{
+			return [];
+		}
+		foreach ($listRecord as &$record)


An array of new records would be cleaner than &.

jayay · 2021-12-28T13:01:55Z

plugin/Installer/DatabaseChanges.php

@@ -274,6 +281,7 @@ private function getCreateQueryForms()
 			`radius` INT( 10 ) NULL DEFAULT NULL,
 			`geo_order` VARCHAR( 255 ) NOT NULL DEFAULT 'street,zip,city,country,radius',
 			`show_estate_context` tinyint(1) NOT NULL DEFAULT '0',
+			`page_shortcode` tinytext NOT NULL,


isn't this duplicate information? This is the name with some constant string left and right. Totally reproducible.

jayay · 2022-01-07T14:24:20Z

plugin/Gui/Table/EstateListTable.php

@@ -119,6 +124,31 @@ private function fillData()
 		]);
 	}

+	private function handleRecord($listRecord)


This is still open

jayay · 2022-01-07T14:24:30Z

plugin/Gui/Table/EstateListTable.php

+				$page = '';
+				foreach ($listPageID as $pageID)
+				{
+					if (!empty($page))


this is still open, too

…orms-estates-and-addresses

michaelarnold-dev · 2022-02-28T14:39:29Z

@hungnc89 test feedback "Test with version 2.21.4-13-gd93dcbf6 installed on https://wpptest.onofficeweb.com/. See also the attached video.

Errors.mp4

1.) After installing the project code all previously created lists, forms etc. are gone. When switching back to another code, they are there again.
2.) After saving a list or a form it does not appear in list view.
3.) The names from the screenshots are used everywhere. But the names from the text in the requirements are the relevant ones. Only for forms instead of "List name" is better "Form name"."

tang-hien-egs · 2022-03-02T04:20:15Z

@hungnc89 test feedback "Test with version 2.21.4-13-gd93dcbf6 installed on https://wpptest.onofficeweb.com/. See also the attached video.

Errors.mp4
1.) After installing the project code all previously created lists, forms etc. are gone. When switching back to another code, they are there again. 2.) After saving a list or a form it does not appear in list view. 3.) The names from the screenshots are used everywhere. But the names from the text in the requirements are the relevant ones. Only for forms instead of "List name" is better "Form name"."

@michaelarnold-dev , i tested in localhost oki, i recorded in video like link : https://files.fm/f/87gz62b92, can you check and upgrade db_version ?

michaelarnold-dev · 2022-03-08T06:52:34Z

@tang-hien-egs Robert said that 3) is still open. He asks you to consider these values /fields

1.1) Add the following columns to the estate list overview:

List name
Selected filter
Template
List type
Shortcode
Pages using the shortcode

1.2) For the forms:

Form name
Recipient e-mail address
Template
Form type
Shortcode
Pages using the shortcode

1.3) For addresses:

List name
Selected filter
Template
List type
Shortcode
Pages using the shortcode

tang-hien-egs · 2022-03-10T02:12:33Z

@tang-hien-egs Robert said that 3) is still open. He asks you to consider these values /fields

1.1) Add the following columns to the estate list overview:

List name

Selected filter

Template

List type

Shortcode

Pages using the shortcode

1.2) For the forms:

Form name

Recipient e-mail address

Template

Form type

Shortcode

Pages using the shortcode

1.3) For addresses:

List name

Selected filter

Template

List type

Shortcode

Pages using the shortcode

@michaelarnold-dev , i fixed it, can you check it ?

tang-hien-egs · 2022-03-10T08:07:54Z

@michaelarnold-dev , i tested local and record video like link : https://files.fm/f/yqk2a5zwr

jayay · 2022-03-10T15:08:59Z

@tang-hien-egs could you please clean up the code from your last commit?

tang-hien-egs · 2022-03-10T16:23:25Z

@tang-hien-egs could you please clean up the code from your last commit?

@jayay i fixed it and fixed conflict, can you check PR help me ?

TangHien4698 added 6 commits November 1, 2021 09:02

add Optimize columns on list views for forms, estates, and addresses

d31dcf7

Change query insert ignore

9994a40

fix conflict

f392f3b

how to fix conflict

401cb15

Merge branch 'master' into 56183-Optimize-columns-on-list-views-for-f…

9ef6fe3

…orms-estates-and-addresses

update unit test change database

35b06b5

tung-le-esg requested a review from jayay December 20, 2021 03:54

jayay reviewed Dec 22, 2021

View reviewed changes

update test

6444b38

jayay suggested changes Dec 28, 2021

View reviewed changes

fix code under review

68246c1

vu-vuong-esg requested a review from jayay January 4, 2022 02:55

jayay suggested changes Jan 7, 2022

View reviewed changes

56183-Optimize-columns-on-list-views-for-forms-estates-and-addresses

500acc0

vu-vuong-esg force-pushed the 56183-Optimize-columns-on-list-views-for-forms-estates-and-addresses branch from c0347a8 to 500acc0 Compare January 12, 2022 01:58

Merge branch 'master' into 56183-Optimize-columns-on-list-views-for-f…

b9a488f

…orms-estates-and-addresses

vu-vuong-esg requested a review from jayay January 12, 2022 09:47

update oder field Alpha

6609639

nglelinh removed the request for review from jayay January 26, 2022 09:14

TangHien4698 added 2 commits January 26, 2022 16:43

Merge branch 'master' into 56183-Optimize-columns-on-list-views-for-f…

5e5f6b1

…orms-estates-and-addresses

add exception

d93dcbf

jayay approved these changes Jan 31, 2022

View reviewed changes

fix conflict file DatabaseChanges

58f40d2

jayay approved these changes Feb 21, 2022

View reviewed changes

hungnc89 mentioned this pull request Feb 24, 2022

P#63827 Add a default email address #186

Merged

fix conflict change database and change label

f3602d7

change delete page use shortcode

38668ef

tang-hien-egs and others added 2 commits March 10, 2022 23:02

romove comment in code

893ac08

Fix conflict file database and file mo

9117224

jayay approved these changes Mar 11, 2022

View reviewed changes

michaelarnold-dev merged commit 7f029b8 into master Mar 15, 2022

jayay deleted the 56183-Optimize-columns-on-list-views-for-forms-estates-and-addresses branch March 15, 2022 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

P#56183 Optimize columns on list views for forms estates and addresses #139

P#56183 Optimize columns on list views for forms estates and addresses #139

tung-le-esg commented Nov 17, 2021

coveralls commented Dec 20, 2021 •

edited

Loading

jayay Dec 22, 2021

jayay Dec 28, 2021

jayay Dec 28, 2021

jayay Dec 28, 2021

jayay Jan 7, 2022

jayay Dec 28, 2021

jayay Jan 7, 2022

jayay Dec 28, 2021

jayay Dec 28, 2021

jayay Dec 28, 2021

jayay Jan 7, 2022

jayay Jan 7, 2022

michaelarnold-dev commented Feb 28, 2022

tang-hien-egs commented Mar 2, 2022

michaelarnold-dev commented Mar 8, 2022

tang-hien-egs commented Mar 10, 2022

tang-hien-egs commented Mar 10, 2022

jayay commented Mar 10, 2022

tang-hien-egs commented Mar 10, 2022

P#56183 Optimize columns on list views for forms estates and addresses #139

P#56183 Optimize columns on list views for forms estates and addresses #139

Conversation

tung-le-esg commented Nov 17, 2021

coveralls commented Dec 20, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1964212787

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaelarnold-dev commented Feb 28, 2022

tang-hien-egs commented Mar 2, 2022

michaelarnold-dev commented Mar 8, 2022

tang-hien-egs commented Mar 10, 2022

tang-hien-egs commented Mar 10, 2022

jayay commented Mar 10, 2022

tang-hien-egs commented Mar 10, 2022

coveralls commented Dec 20, 2021 •

edited

Loading