Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IDE data from repository #17

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Remove IDE data from repository #17

merged 2 commits into from
Aug 25, 2021

Conversation

mrcodefinger
Copy link
Contributor

Hi!
I have added the .idea folder to the .gitignore. On the one hand my IDE settings are partly overwritten, on the other hand I think that this data does not belong in a repository. I recommend to add the .idea folder to the .gitignore_global.
Kind regards!

@jayay
Copy link
Contributor

jayay commented Sep 2, 2020

This was done on purpose as it is the only way for us to keep our settings in sync. It is also an officially documented feature of Intellij IDEs. So why not?
Which settings were overwritten in your environment? Maybe it would be better to solve that specific issue.

@mrcodefinger
Copy link
Contributor Author

Each development environment has its own optimizations and sometimes different platforms, tasks, settings and folder structures. Every developer should have the freedom to use his own IDE in his own productive way. IDE's are local tools, they are not linked to the project. If not, .vscode, .elipse, .vim and so on should also be considered. I will not blindly trust the IDE creators, for them it is a business, for me it is just a tool. If I'm informed correctly, you should share global settings via the .editorconf in a separate repository if you want to, but this overrides the built-in cloudsync function of PHPStorm.

@jayay
Copy link
Contributor

jayay commented Sep 2, 2020

Please see here: https://www.jetbrains.com/help/idea/sharing-your-ide-settings.html

For information on how to share settings related to specific projects, see Share project settings through VCS.

The project specific settings are supposed to be shared through VCS.

Each developer can configure their IDE in their own way. But project specific settings require the biggest amount of time and it is only a pleasure to each individual developer if they come just with the project. We use this feature internally as well and from my experience I can tell it is so much harder if each individual developer needs to configure the exact same settings in order to get the same setup. I would be open to fixing the issue that you have encountered while getting this running inside your IDE, but deleting the settings entirely would be counter-productive.

@mrcodefinger
Copy link
Contributor Author

mrcodefinger commented Sep 2, 2020

In the documentation you posted there it is also recommended to share settings via a separate private repository ;-)
https://www.jetbrains.com/help/idea/sharing-your-ide-settings.html#import-export-settings

@pmaasz
Copy link

pmaasz commented Sep 22, 2020

It is uncommon to publish the .idea/ directory in the same repo as the code.

@jayay
Copy link
Contributor

jayay commented Feb 8, 2021

I asked around and no one seemed to need the .idea directory. Will merge once the master branch is clean.

@jayay jayay added the waiting label Jun 11, 2021
@jayay jayay merged commit 8fb1023 into onOffice-Web-Org:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants