P#63827 Add a default email address #186

hungnc89 · 2022-02-24T03:45:44Z

No description provided.

hungnc89 · 2022-02-24T04:19:21Z

@jayay This task has not been finished yet because it is depended on #139. That PR is not merged.

jayay · 2022-03-15T13:09:46Z

#139 was merged today 🎉

…s' into 63827_add_a_default_email_address # Conflicts: # languages/onoffice-for-wp-websites-de_DE.mo # languages/onoffice-for-wp-websites-de_DE.po # languages/onoffice-for-wp-websites-es_ES.mo # languages/onoffice-for-wp-websites-es_ES.po # languages/onoffice-for-wp-websites-it_IT.mo # languages/onoffice-for-wp-websites-it_IT.po # languages/onoffice-for-wp-websites-nl_NL.mo # languages/onoffice-for-wp-websites-nl_NL.po # languages/onoffice-for-wp-websites.pot # plugin/Controller/AdminViewController.php # plugin/Installer/DatabaseChanges.php

coveralls · 2022-03-21T11:41:59Z

Pull Request Test Coverage Report for Build 2407625054

56 of 84 (66.67%) changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 81.363%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
plugin/Controller/AdminViewController.php	10	11	90.91%
plugin/FormPostContact.php	2	3	66.67%
plugin/Renderer/InputFieldEmailRenderer.php	9	10	90.0%
plugin/Model/InputModelBase.php	1	4	25.0%
plugin/Record/RecordManagerReadForm.php	0	5	0.0%
plugin/Model/FormModelBuilder/FormModelBuilderDBForm.php	20	28	71.43%
plugin/Renderer/InputModelRenderer.php	0	9	0.0%

Totals
Change from base Build 2396840137:	0.6%
Covered Lines:	6793
Relevant Lines:	8349

💛 - Coveralls

plugin/Gui/Table/WP/ListTable.php

update getCountDefaultRecipientRecord func add param to contruct of displayUsingEmptyDefaultEmailError func

…_email_address

plugin/Gui/Table/WP/ListTable.php

plugin/Renderer/InputModelRenderer.php

add escaping to recipient email

plugin/Renderer/InputModelRenderer.php

…_email_address # Conflicts: # languages/onoffice-for-wp-websites-de_DE.mo # languages/onoffice-for-wp-websites-es_ES.mo # languages/onoffice-for-wp-websites-it_IT.mo # languages/onoffice-for-wp-websites-nl_NL.mo

github-actions · 2022-04-20T06:55:34Z

Steps to install the approved version:

Download onoffice-3.0-17-gf59894e0-please-unpack.zip from https://github.com/onOfficeGmbH/oo-wp-plugin/actions/runs/2194063221.
Unpack the downloaded file to get another .zip file.
Upload that inner .zip file to WordPress.

jmaas-onoffice

When I upgrade from the released v3.0, I get the following error on the forms overview:

Unfortunately, none of the test instances seems free at the moment. If you can't reproduce the issue, please tell me and we will wait until a test instance is free.

github-actions · 2022-05-24T06:45:39Z

Steps to install the approved version:

Download onoffice-3.2-45-g213612bc-please-unpack.zip from https://github.com/onOfficeGmbH/oo-wp-plugin/actions/runs/2375971300.
Unpack the downloaded file to get another .zip file.
Upload that inner .zip file to WordPress.

jmaas-onoffice

For the contact form, the email override starts out deactivated as desired. For interest and owner forms, it starts out activated and when the default email is active, it suddenly gets disabled after loading. Please make it consistent with the contact form for all form types.
In the contact form, the label for the email is "Override email address", but for the other form types it is "Override Recipient's E-Mail Address". Please make it consistent and use "Override email address" for all form types.

github-actions · 2022-05-25T08:29:55Z

Steps to install the approved version:

Download onoffice-3.2-46-ge8b400e5-please-unpack.zip from https://github.com/onOfficeGmbH/oo-wp-plugin/actions/runs/2383152235.
Unpack the downloaded file to get another .zip file.
Upload that inner .zip file to WordPress.

LongTrong-exe · 2022-05-26T06:51:20Z

@jmaas-onoffice On master branch, email input in all forms has type 'text', so I update it to 'email' type and add email validation when saving form.

jmaas-onoffice · 2022-05-27T07:52:51Z

@LongTrong-exe Yes, that sounds good, thanks.

I think we had some discussion on how to validate email addresses in another PR, but I can't find it. The conclusion was: Don't do anything complicated, type="email" is enough. ;)

jmaas-onoffice · 2022-05-27T09:03:45Z

Oh, I didn't see that you already requested my review. I will have a look!

jmaas-onoffice · 2022-05-27T09:45:06Z

js/ajax_settings.js

+		var typesNeedValid = ['email'];
+
+		form.submit(function (e) {
+			e.preventDefault();


I'm a bit confused by this. Why do we need to prevent the form from sending and validate and save it ourselves here? Shouldn't that be something we do in #160?

I think it would be better to fix that in #160

This reverts commit 06f20a6

# Conflicts: # plugin/Installer/DatabaseChanges.php

This reverts commit b44899a.

github-actions · 2022-05-30T11:51:08Z

Steps to install the approved version:

Download onoffice-3.2-62-g914b1701-please-unpack.zip from https://github.com/onOfficeGmbH/oo-wp-plugin/actions/runs/2408834411.
Unpack the downloaded file to get another .zip file.
Upload that inner .zip file to WordPress.

63827 Add a default email address

48ac3e0

nglelinh added 2 commits March 21, 2022 13:19

63827 Add a default email address

55f8c73

jayay reviewed Mar 22, 2022

View reviewed changes

plugin/Gui/Table/WP/ListTable.php Outdated Show resolved Hide resolved

nglelinh added 5 commits March 24, 2022 11:29

add unittest

8d621c4

update getCountDefaultRecipientRecord func add param to contruct of displayUsingEmptyDefaultEmailError func

Merge remote-tracking branch 'origin/master' into 63827_add_a_default…

fd2d083

…_email_address

add unittest

0e37080

add unittest

50c9cf0

update pot

2b33e37

jayay suggested changes Mar 24, 2022

View reviewed changes

plugin/Gui/Table/WP/ListTable.php Outdated Show resolved Hide resolved

plugin/Renderer/InputModelRenderer.php Outdated Show resolved Hide resolved

nglelinh added 2 commits March 25, 2022 11:00

update displayUsingEmptyDefaultEmailError func

bed8ab0

add escaping to recipient email

reformat code

d8e17a5

jmaas-onoffice added the feedback-jakob label Mar 30, 2022

jmaas-onoffice removed the feedback-jakob label Apr 7, 2022

jmaas-onoffice self-requested a review April 7, 2022 12:41

jmaas-onoffice suggested changes Apr 8, 2022

View reviewed changes

plugin/Renderer/InputModelRenderer.php Outdated Show resolved Hide resolved

nglelinh added 2 commits April 20, 2022 09:10

63827: remove attribute 'pattern' from email input

f59894e

hungnc89 requested a review from jmaas-onoffice April 20, 2022 06:10

jmaas-onoffice approved these changes Apr 20, 2022

View reviewed changes

jmaas-onoffice suggested changes Apr 20, 2022

View reviewed changes

nglelinh added 3 commits April 21, 2022 10:20

P#63827: Add field 'default_recipient' to database

d07f64c

P#63827: update database max_version

41a7a5a

P#63827: update unittest

29001bc

hungnc89 requested a review from jmaas-onoffice April 21, 2022 04:51

jmaas-onoffice approved these changes Apr 21, 2022

View reviewed changes

LongTrong-exe dismissed jmaas-onoffice’s stale review via 2420a33 May 23, 2022 15:31

update test

213612b

LongTrong-exe requested a review from jmaas-onoffice May 24, 2022 02:50

jmaas-onoffice approved these changes May 24, 2022

View reviewed changes

jmaas-onoffice suggested changes May 24, 2022

View reviewed changes

update form email input

e8b400e

LongTrong-exe previously approved these changes May 25, 2022

View reviewed changes

valid email input when save form.

06f20a6

LongTrong-exe dismissed their stale review via 06f20a6 May 26, 2022 06:27

update test

a2544af

LongTrong-exe requested a review from jmaas-onoffice May 26, 2022 06:51

update test

443804f

jmaas-onoffice suggested changes May 27, 2022

View reviewed changes

LongTrong-exe added 3 commits May 30, 2022 10:50

Revert "valid email input when save form."

4b2ccf1

This reverts commit 06f20a6

Merge branch 'master' into 63827_add_a_default_email_address

e39c476

# Conflicts: # plugin/Installer/DatabaseChanges.php

update test

7dfedf6

LongTrong-exe requested a review from jmaas-onoffice May 30, 2022 07:35

dai-eastgate added 2 commits May 30, 2022 14:55

validate email without form submit

b44899a

Revert "validate email without form submit"

914b170

This reverts commit b44899a.

LongTrong-exe requested review from jmaas-onoffice and removed request for jmaas-onoffice May 30, 2022 08:15

jmaas-onoffice approved these changes May 30, 2022

View reviewed changes

jmaas-onoffice merged commit 29535f2 into master May 30, 2022

jmaas-onoffice deleted the 63827_add_a_default_email_address branch May 30, 2022 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

P#63827 Add a default email address #186

P#63827 Add a default email address #186

hungnc89 commented Feb 24, 2022

hungnc89 commented Feb 24, 2022 •

edited

Loading

jayay commented Mar 15, 2022

coveralls commented Mar 21, 2022 •

edited

Loading

github-actions bot commented Apr 20, 2022

jmaas-onoffice left a comment

github-actions bot commented May 24, 2022

jmaas-onoffice left a comment •

edited

Loading

github-actions bot commented May 25, 2022

LongTrong-exe commented May 26, 2022

jmaas-onoffice commented May 27, 2022

jmaas-onoffice commented May 27, 2022

jmaas-onoffice May 27, 2022

LongTrong-exe May 30, 2022

github-actions bot commented May 30, 2022

P#63827 Add a default email address #186

P#63827 Add a default email address #186

Conversation

hungnc89 commented Feb 24, 2022

hungnc89 commented Feb 24, 2022 • edited Loading

jayay commented Mar 15, 2022

coveralls commented Mar 21, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2407625054

💛 - Coveralls

github-actions bot commented Apr 20, 2022

jmaas-onoffice left a comment

Choose a reason for hiding this comment

github-actions bot commented May 24, 2022

jmaas-onoffice left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 25, 2022

LongTrong-exe commented May 26, 2022

jmaas-onoffice commented May 27, 2022

jmaas-onoffice commented May 27, 2022

jmaas-onoffice May 27, 2022

Choose a reason for hiding this comment

LongTrong-exe May 30, 2022

Choose a reason for hiding this comment

github-actions bot commented May 30, 2022

hungnc89 commented Feb 24, 2022 •

edited

Loading

coveralls commented Mar 21, 2022 •

edited

Loading

jmaas-onoffice left a comment •

edited

Loading