Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30852 Custom label doesn't work on first save in Similar Estate and Detail Estate #457

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Feb 27, 2023

related to #442

changed log :
add custom label similar estate & detail estate

@coveralls
Copy link

coveralls commented Feb 27, 2023

Pull Request Test Coverage Report for Build 4561555618

  • 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 78.742%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Field/FieldModuleCollectionDecoratorCustomLabelEstate.php 3 5 60.0%
plugin/EstateList.php 2 5 40.0%
Totals Coverage Status
Change from base Build 4559977414: 0.07%
Covered Lines: 7334
Relevant Lines: 9314

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Steps to install the approved version:

  1. Download onoffice-4.9-31-g47f891fb-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/4605801332.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit c4dbff4 into master Apr 4, 2023
@andernath andernath deleted the 30852-custom-label-does-not-work-on-first-save-in-similar-estate-and-detail-estate branch April 4, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants