Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33244 hot fix enterprise deactivated fields will lead to critical error #497

Merged
merged 5 commits into from
Apr 17, 2023
Merged

33244 hot fix enterprise deactivated fields will lead to critical error #497

merged 5 commits into from
Apr 17, 2023

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Apr 12, 2023 •
edited
Loading

related to #496

changed log :
Filter active input fields

@coveralls
Copy link

coveralls commented Apr 12, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 4687437415

  • 23 of 28 (82.14%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.714%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Renderer/InputFieldComplexSortableDetailListRenderer.php 0 1 0.0%
plugin/EstateList.php 15 17 88.24%
plugin/FormPost.php 8 10 80.0%
Totals Coverage Status
Change from base Build 4666109071: 0.01%
Covered Lines: 7359
Relevant Lines: 9349
💛 - Coveralls

@dai-eastgate dai-eastgate mentioned this pull request Apr 12, 2023
Closed
@github-actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.10-5-gd40dd312-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/4718906280.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit bea9a59 into master Apr 17, 2023
@andernath andernath deleted the 33244-hot-fix-in-enterprise-deactivated-fields-will-lead-to-critical-error branch April 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andernath andernath andernath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dai-eastgate @coveralls @andernath