34563 Map in property listing #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5734723768
💛 - Coveralls |
fredericalpers
added
the
documentation
Closed
andernath
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Finished review and I think we need a manual merge here. Please check @yeneastgate :)
plugin/Installer/DatabaseChanges.php
Outdated
| @@ -44,7 +44,7 @@ | |||
| class DatabaseChanges implements DatabaseChangesInterface | |||
| { | |||
| /** @var int */ | |||
| const MAX_VERSION = 38; | |||
| const MAX_VERSION = 39; | |||
There was a problem hiding this comment.
We used Version 39 in [32990 Price on request].
Is it possible to do multiple changes with one dbversion? Or does every change need new dbversion?
Could you @yeneastgate merge master in this branch please and resolve conflicts?
There was a problem hiding this comment.
@andernath Yes, I will resolve conflicts and merge this branch into master
There was a problem hiding this comment.
@yeneastgate for a valid test we need to merge master into this branch first
Edit: Oh I see you already did, thank you :)
|
Steps to install the approved version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #516
changed log :
Add checkbox to show map in estate list