37596 PDF Download in property lists #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9541106346Details
💛 - Coveralls |
andernath
reviewed
Sep 28, 2023
There was a problem hiding this comment.
@yeneastgate @dai-eastgate
I finished review, looks good.
Please check my comment.
| $pInputModelDocumentTypes = $pFormModelBuilder->createInputModelExpose(); | ||
| $pFormModelDocumentTypes = new FormModel(); | ||
| $pFormModelDocumentTypes->setPageSlug($this->getPageSlug()); | ||
| $pFormModelDocumentTypes->setGroupSlug(self::FORM_VIEW_DOCUMENT_TYPES); |
There was a problem hiding this comment.
I think with this changes FORM_VIEW_DOCUMENT_TYPES initialized in AdminPageEstateListSettingsBase.php is never used anymore.
Also FORM_VIEW_FIELDS_CONFIG in AdminPageEstateListSettingsBase.php seems not to be used.
Could you please check it and remove unused constants?
There was a problem hiding this comment.
@andernath I will check and remove it.
|
Steps to install the approved version:
|
fredericalpers
added
the
up for discussion
fredericalpers
removed
the
up for discussion
|
Nach erneuter Rücksprache soll das Feature hier weiterhin entfernt werden, da es an dieser Stelle keinen Sinn macht. |
fredericalpers
added
component: property list
|
Steps to install the approved version:
|
andernath
approved these changes
Aug 1, 2024
|
Steps to install the approved version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #590
changed log :
Remove PDF download in property lists and unit lists.