Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38234 Each form leads to many queries for default values #604

Merged

Conversation

yeneastgate
Copy link
Contributor

@yeneastgate yeneastgate commented Aug 4, 2023

related to #557

changed log :
Fix default value for better performance.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Pull Request Test Coverage Report for Build 6479998522

  • 116 of 116 (100.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 79.289%

Files with Coverage Reduction New Missed Lines %
plugin/Form.php 5 30.67%
Totals Coverage Status
Change from base Build 6479684394: 0.01%
Covered Lines: 7607
Relevant Lines: 9594

💛 - Coveralls

@yeneastgate yeneastgate force-pushed the 38234-each-form-leads-to-many-queries-for-default-values branch from 7376419 to 2183088 Compare August 4, 2023 07:05
@fredericalpers fredericalpers added this to the v4.15 milestone Aug 8, 2023
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Aug 8, 2023
@fredericalpers fredericalpers linked an issue Aug 8, 2023 that may be closed by this pull request
@fredericalpers fredericalpers removed the QA Issue or Pull request that is in review label Aug 8, 2023
@yeneastgate yeneastgate force-pushed the 38234-each-form-leads-to-many-queries-for-default-values branch from ae13af1 to 065cfce Compare August 10, 2023 09:22
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Aug 22, 2023
Copy link
Contributor

@andernath andernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will start testing

@github-actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.14-12-g3647264d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/6465824723.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath added the up for discussion Issues and Pull Requests which will be discussed label Oct 10, 2023
@fredericalpers
Copy link
Member

@yeneastgate please let us know how you setup your tests here? we can not reproduce the test results. Our tests sometimes are a little better but also sometimes worse.

@yeneastgate
Copy link
Contributor Author

@yeneastgate please let us know how you setup your tests here? we can not reproduce the test results. Our tests sometimes are a little better but also sometimes worse.

@fredericalpers @andernath This is a video of how I test performance.

  • Master Branch:
master.mp4

image

  • Branch 38234 Each form leads to many queries for default values:
branch.mp4

image

@fredericalpers fredericalpers removed the up for discussion Issues and Pull Requests which will be discussed label Oct 16, 2023
@andernath andernath merged commit 0908383 into master Oct 16, 2023
3 checks passed
@andernath andernath deleted the 38234-each-form-leads-to-many-queries-for-default-values branch October 16, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each form leads to many queries for default values
4 participants