Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

38279 Third party libraries and scripts #612

Merged
merged 3 commits into from
Oct 11, 2023
Merged

38279 Third party libraries and scripts #612

merged 3 commits into from
Oct 11, 2023

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Aug 15, 2023 •
edited
Loading

related to #574

changed log :
Add asynchronous loading attribute to third-party library

@fredericalpers fredericalpers added this to the v4.15 milestone Aug 15, 2023
@fredericalpers fredericalpers linked an issue Aug 15, 2023 that may be closed by this pull request
Third party libraries and scripts #574
Closed
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5874081691

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.076%
Totals Coverage Status
Change from base Build 5853337167: 0.01%
Covered Lines: 7513
Relevant Lines: 9501
💛 - Coveralls

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Aug 16, 2023
@yeneastgate yeneastgate requested a review from andernath August 24, 2023 03:17
andernath
andernath approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@andernath andernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will start testing

@github-actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.12.1-9-g3fddca35-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/6479195002.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit 162b969 into master Oct 11, 2023
3 checks passed
@andernath andernath deleted the 38279-third-party-libraries-and-scripts branch October 11, 2023 08:04
@andernath andernath added ready for release and removed QA Issue or Pull request that is in review labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andernath andernath andernath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.15
Development

Successfully merging this pull request may close these issues.

Third party libraries and scripts
3 participants
@dai-eastgate @andernath @fredericalpers