Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40395 Multiple forms with reCAPTCHA lead to wrong submission #648

Merged
merged 13 commits into from
Nov 6, 2023
Merged

40395 Multiple forms with reCAPTCHA lead to wrong submission #648

merged 13 commits into from
Nov 6, 2023

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Oct 2, 2023 •
edited
Loading

related to #631

changed log :
Update multiple forms with reCAPTCHA

@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6743365649

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.263%
Totals Coverage Status
Change from base Build 6730028100: 0.0%
Covered Lines: 7618
Relevant Lines: 9611
💛 - Coveralls

@yeneastgate yeneastgate force-pushed the 40395-multiple-forms-with-recaptcha-lead-to-wrong-submission branch from 3b7e22d to 9052922 Compare October 2, 2023 10:15
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Oct 4, 2023
@fredericalpers fredericalpers added this to the v4.17 milestone Oct 4, 2023
@andernath andernath modified the milestones: v4.17, v4.15.1 Oct 31, 2023
@fredericalpers fredericalpers linked an issue Oct 31, 2023 that may be closed by this pull request
Multiple forms with reCAPTCHA lead to wrong submission #631
Closed
@andernath
Copy link
Contributor

andernath commented Oct 31, 2023 •
edited
Loading

@yeneastgate could you please resolve conflicts and merge master into this branch?

@yeneastgate
Copy link
Contributor

@yeneastgate could you please resolve conflicts and merge master into this branch?

I have merged and test it again. However, there are some problems I need to check. I will get back to you asap. Thanks.

@yeneastgate yeneastgate force-pushed the 40395-multiple-forms-with-recaptcha-lead-to-wrong-submission branch from 525efc8 to 23c8382 Compare November 3, 2023 04:25
@yeneastgate yeneastgate force-pushed the 40395-multiple-forms-with-recaptcha-lead-to-wrong-submission branch from 23c8382 to 3dd0f8c Compare November 3, 2023 07:14
@yeneastgate
Copy link
Contributor

@andernath @fredericalpers I have fixed and tested this PR. Please help us to review. Thanks!
Here is a video demo: https://files.fm/f/scgt9zhdnz

andernath
andernath approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@andernath andernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will start testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Steps to install the approved version:

  1. Download onoffice-4.15-16-g2f520209-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/6767753300.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath mentioned this pull request Nov 6, 2023
Closed
@andernath
Copy link
Contributor

@dai-eastgate and @yeneastgate
Test looks good!
But I found a bug, which seems to be connected with recapcha loading.
I created a Issue for 4.16: #669

@andernath andernath merged commit f5565ce into master Nov 6, 2023
6 checks passed
@andernath andernath deleted the 40395-multiple-forms-with-recaptcha-lead-to-wrong-submission branch November 6, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andernath andernath andernath approved these changes

Assignees
No one assigned
Labels
QA Issue or Pull request that is in review
Projects
None yet
Milestone
v4.15.1
Development

Successfully merging this pull request may close these issues.

Multiple forms with reCAPTCHA lead to wrong submission
4 participants
@dai-eastgate @andernath @yeneastgate @fredericalpers