42302 Can't remove/delete secrets and keys #680
Conversation
Pull Request Test Coverage Report for Build 8683894277Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
fredericalpers
added
UI/UX
| @@ -15,4 +15,19 @@ jQuery(document).ready(function ($) { | |||
|
|
|||
| jQuery.post(warning_active_plugin_vars.ajaxurl, data); | |||
| }); | |||
|
|
|||
| $(document).on('click', '.delete-google-recaptcha-keys-button', function (event) { | |||
| if (confirm('Would you like to permanently delete the site key and the secret key?')) { | |||
There was a problem hiding this comment.
Please use a textkey which can be translated
| @@ -0,0 +1,22 @@ | |||
| jQuery(document).ready(function ($) { | |||
| function showOrHiddenGoogleRecaptchaKey(inputSelector, toggleSelector) { | |||
There was a problem hiding this comment.
showOrHideGoogleRecaptchaKey
| @@ -0,0 +1,39 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I'm not sure if this renderer is necessary.
What do you think to put this button inside of InputFieldPassworkRenderer and maybe rename it? Or do you think this is bad practice and every single element has to be a seperated class?
css/admin.css
Outdated
| @@ -460,8 +460,48 @@ body #post-head-content p.wp-clearfix:nth-child(1) { | |||
| font-size: 14px; | |||
| white-space: nowrap; | |||
| } | |||
|
|
|||
| .oo-google-recaptcha-key { | |||
There was a problem hiding this comment.
media stylings should be a the end of css file to overwrite the styling on different devices. Please move the whole media block to the end and I'm sure you can remove the !important tag
|
@andernath I will check it |
|
@andernath I have updated the code and here is video demo https://files.fm/u/ddegpwe8v5 |
There was a problem hiding this comment.
Thanks @dai-eastgate for refactoring! :)
I just got rid of the last !important tags in CSS, with a more specefic selector
|
Steps to install the approved version:
|
#4180311
|
@dai-eastgate On first load the css seems not to be loaded correctly. Only if I open the console and reload it is fixed. Please check and fix this behaviour.
|
@fredericalpers This bug occurs because the browser cache has not been cleared, so it is saving the CSS in the old branch. When you checkout to a new branch, make sure you clear your browser cache |
related to #677
changed log:
Add delete button and show keys