Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

42592 OpenGraph support #688

Merged
merged 25 commits into from
May 16, 2024
Merged

42592 OpenGraph support #688

merged 25 commits into from
May 16, 2024

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Nov 28, 2023 •
edited
Loading

related to #673
changed log:
Add meta tag for Open Graph and Twitter Cards

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 8014219503

Details

  • -18 of 190 (90.53%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 79.771%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Renderer/InputModelRenderer.php 0 3 0.0%
plugin/EstateList.php 36 43 83.72%
plugin/GenerateMetaDataSocial.php 129 137 94.16%
Totals Coverage Status
Change from base Build 7970490232: 0.2%
Covered Lines: 7950
Relevant Lines: 9966
💛 - Coveralls

@fredericalpers fredericalpers added this to the v4.19 milestone Dec 13, 2023
@fredericalpers fredericalpers linked an issue Dec 13, 2023 that may be closed by this pull request
OpenGraph support #673
Closed
5 tasks
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Dec 13, 2023
@fredericalpers fredericalpers added component: property detail page Issue, Pull Request or Discussion related to property detail page component: dashboard Issue, Pull Request or Discussion related to dashboard / settings page feature New feature labels Feb 20, 2024
@fredericalpers fredericalpers modified the milestones: v4.19, v4.20 Feb 23, 2024
@miauzjpg miauzjpg added the deploy test Triggers event to create test version label May 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Steps to install the approved version:

  1. Download onoffice-4.19-27-gffe10306-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8935653667.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

miauzjpg
miauzjpg previously approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 💪

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Steps to install the approved version:

  1. Download onoffice-4.19-27-gffe10306-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8936256789.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

andernath added 2 commits May 13, 2024 08:26
@andernath
Add SEO Plugin check for adding meta tags
103864b 
Refactor Code
#4237073
@andernath
Change oder of meta tags
30bea5b 
Refactor Code
#4237073
@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels May 14, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-34-g30bea5b0-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9075737255.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

andernath added 2 commits May 14, 2024 11:14
@andernath
Fix typo
1d8e01a 
#4246561
@andernath
refactoring
64fc45a 
#4246561
@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels May 16, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-36-g64fc45a0-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9107612500.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

miauzjpg
miauzjpg reviewed May 16, 2024
View reviewed changes
plugin/Model/InputModelBase.php Outdated
const HTML_TYPE_ITALIC_LABEL_CHECKBOX = 'italicLabelCheckbox';

/** */
/** */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the code formatting

@miauzjpg
Update InputModelBase.php
63637da 
fixed formatting
miauzjpg
miauzjpg approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 😊

@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-37-g63637da6-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9109582846.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg merged commit 06f2105 into master May 16, 2024
6 checks passed
@miauzjpg miauzjpg deleted the 42592-opengraph-support branch May 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miauzjpg miauzjpg miauzjpg approved these changes

Assignees
No one assigned
Labels
component: dashboard Issue, Pull Request or Discussion related to dashboard / settings page component: property detail page Issue, Pull Request or Discussion related to property detail page deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Milestone
v4.20
Development

Successfully merging this pull request may close these issues.

OpenGraph support
4 participants
@dai-eastgate @miauzjpg @fredericalpers @andernath