Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

43299 settings pages property list loading time #712

Merged
merged 17 commits into from
Jun 5, 2024
Merged

43299 settings pages property list loading time #712

merged 17 commits into from
Jun 5, 2024

Conversation

yeneastgate
Copy link
Contributor

related to #700
changed log:
Change "chosen" script to "select2" script

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9109740229

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.654%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Renderer/InputModelRenderer.php 0 2 0.0%
Totals Coverage Status
Change from base Build 9109632295: 0.01%
Covered Lines: 8331
Relevant Lines: 10459
💛 - Coveralls

@fredericalpers fredericalpers added this to the v4.20 milestone Jan 8, 2024
@fredericalpers fredericalpers linked an issue Jan 8, 2024 that may be closed by this pull request
Settings pages Property list loading time #700
Closed
4 tasks
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Jan 8, 2024
@fredericalpers fredericalpers added performance Issue, Pull Request or Discussion related to performance component: property detail page Issue, Pull Request or Discussion related to property detail page labels Feb 20, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Apr 30, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-21-g743577f5-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8893878868.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

fredericalpers commented Apr 30, 2024 •
edited by yeneastgate
Loading

@yeneastgate after reviewing this I came to the conclusion that we have to make a few more adjustments.

  • The "x" for deselecting the items ideally should be an SVG-file e.g. SVG Icon Close.
  • The "x" icon should be added as a <button> and must have a larger clickable area.
  • Please try to avoid using floats. In this example "float: left;". :)

@fredericalpers fredericalpers removed the deploy test Triggers event to create test version label Apr 30, 2024
@yeneastgate yeneastgate force-pushed the 43299-settings-pages-property-list-loading-time branch from 662696c to f2b0f99 Compare May 7, 2024 04:23
@yeneastgate
Copy link
Contributor Author

@fredericalpers I used SVG Icon close to replace the "x" icon and this is video evidence
Please check it and let me know your opinion

bandicam_2024-05-06_16-20-34-508.mp4

@fredericalpers fredericalpers added the deploy test Triggers event to create test version label May 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Steps to install the approved version:

  1. Download onoffice-4.19-27-gf2b0f99d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8981200154.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath
Refactoring
30057e2 
#3999579
@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Jun 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Steps to install the approved version:

  1. Download onoffice-4.19-32-g30057e29-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9379363675.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers merged commit 4cbf33a into master Jun 5, 2024
6 checks passed
@fredericalpers fredericalpers deleted the 43299-settings-pages-property-list-loading-time branch June 5, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page deploy test Triggers event to create test version performance Issue, Pull Request or Discussion related to performance QA Issue or Pull request that is in review
Projects
None yet
Milestone
v4.20
Development

Successfully merging this pull request may close these issues.

Settings pages Property list loading time
4 participants
@yeneastgate @fredericalpers @dai-eastgate @andernath