43301 Notification of unsaved changes

[dai-eastgate]

related to #697
changed log:
Update notification of unsaved changes

[coveralls]

Pull Request Test Coverage Report for Build 8996408431

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 79.47%

---

Totals
Change from base Build 8964676066:	0.03%
Covered Lines:	8156
Relevant Lines:	10263

---

💛 - Coveralls

[github-actions]

Steps to install the approved version:

1. Download onoffice-4.19-17-g7f541c43-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8920268593.
2. Unpack the downloaded file to get another .zip file.
3. Upload that inner .zip file to WordPress.

[fredericalpers]

@dai-eastgate Overall, the changes are looking good, but there are a few issues that need to be addressed before merging.

Feedback

1. Links that open in a new tab (target=_blank) are not functioning correctly with the new feature. They should be excluded from this functionality.
2. The internal WordPress message should only be triggered when clicking a menu item in the side-menu or admin-menu
3. When repeatedly clicking different menu items, error messages should not stack below each other. Instead, the newest error message should replace the old one.
4. The browser popup should display the text from the WordPress error message. Currently, after clicking "Reload" in the browser popup, the WordPress error message is loaded afterwards.

Tasks

• Exlude links with target="blank" from the new feature
• Ensure the internal WordPress message is only triggered when clicking a menu item
• Implement logic to prevent stacking of error messages when rerpeatedly clicking different menu items
• Update the browser popup to display the text from the WordPress error messages

Please address these issues and check the tasklist. Once done, feel free to resubmit the PR for further review. Thank you for your efforts! :)

[dai-eastgate]

@fredericalpers I will check it.

[dai-eastgate]

• Update the browser popup to display the text from the WordPress error messages

@fredericalpers According to my investigation, there is currently no solution to update the browser popup to display the text from the WordPress error messages because it is no longer possible to display a custom message in the beforeunload (Please check the documents https://chromestatus.com/feature/5349061406228480)

[dai-eastgate]

@fredericalpers @andernath I have fixed it and here is video demo, please review and test this branch again. Thanks!

https://files.fm/u/pfqdykseyx#/view/j9nnaa54ds

[github-actions]

Steps to install the approved version:

1. Download onoffice-4.19-23-g22a13c54-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8981063102.
2. Unpack the downloaded file to get another .zip file.
3. Upload that inner .zip file to WordPress.

[fredericalpers]

@dai-eastgate When clicking on the menu items in the admin-bar the notification for unsaved changes does not work.

• Implement notification also when using the admin-bar menu items

Please go ahead and make sure it also works when using the admin-bar menu, thank you :)

[dai-eastgate]

@dai-eastgate When clicking on the menu items in the admin-bar the notification for unsaved changes does not work.

• Implement notification also when using the admin-bar menu items

Please go ahead and make sure it also works when using the admin-bar menu, thank you :)

@fredericalpers I have fixed it and here is video demo, please test this branch again. Thanks!

bandicam_2024-05-07_14-26-04-782.mp4

[github-actions]

Steps to install the approved version:

1. Download onoffice-4.19-25-g9945b783-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8997549867.
2. Unpack the downloaded file to get another .zip file.
3. Upload that inner .zip file to WordPress.