43303 Improve pagination #738
Conversation
Pull Request Test Coverage Report for Build 7695323748
💛 - Coveralls |
fredericalpers
added
the
component: property list
|
Steps to install the approved version:
|
plugin/RequestVariablesSanitizer.php
Outdated
| } | ||
| } | ||
| return $pagedData; | ||
| } |
There was a problem hiding this comment.
Is this function good placed as a public function in RequestVariablesSanitizer? I think we don't need getParameterPage() for other function.
What do you think?
Should we place this code in SearchParametersModelBuilderEstate->addParametersForPagination ?
There was a problem hiding this comment.
@andernath You are correct, currently getParameterPage() is not needed for other functions.
I placed this code in SearchParametersModelBuilderEstate->addParametersForPagination. When placing the code at this will make the code more cohesive and easier to maintain.
|
@yeneastgate @dai-eastgate |
@andernath I will check it |
|
Steps to install the approved version:
|
related to #695
changed log:
Improved pagination for multiple pages