-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
44698 unnecessary redirects for multilingual pages with user-friendly urls #740
44698 unnecessary redirects for multilingual pages with user-friendly urls #740
Conversation
Pull Request Test Coverage Report for Build 9575964857Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…al-pages-with-user-friendly-urls
…al-pages-with-user-friendly-urls
…al-pages-with-user-friendly-urls
…al-pages-with-user-friendly-urls
…al-pages-with-user-friendly-urls
Steps to install the approved version:
|
…al-pages-with-user-friendly-urls
…al-pages-with-user-friendly-urls
Steps to install the approved version:
|
@yeneastgate The initial issue has been resolved. However, a new issue has arisen. There is a new redirect occurring. It appears that the URL is first being directed to the language directory with the German URL from https://w3pm.onofficeweb.com/detailseite/45-charmantes-landhaus-in-suedfrankreich/ and then redirected to the URL with the permalink in the desired language: https://w3pm.onofficeweb.com/en/detail-page/45-charming-country-house-in-the/. See attached screenshot. Please investigate this behaviour. |
@fredericalpers We have investigated, the cause of this 301 redirect to error is that the "objekttitel" data is obtained from API read estates call according to the current language selected on the detail page, so for switch languages in the WPML, "objekttitel" will not be data according to the chosen language, it will be data of the current language on the detail page. Look at the illustration below: To fix this error, the solution is to use the API to retrieve "objekttitel" according to the activated language by WPML. For each type of language option, there will be a corresponding "objekttitel" |
@dai-eastgate please go ahead and implement the recommended solution :) |
@fredericalpers Currently, I have implemented a trial version to resolve the status 301 error. Below is the test video and performance compared to master: 740_videoCommentKhach.mp4 |
…al-pages-with-user-friendly-urls
Steps to install the approved version:
|
Steps to install the approved version:
|
…al-pages-with-user-friendly-urls
related to #731
Update user-friendly URLs for multilingual pages