Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

44700 energy certificate data on detail pages #742

Merged
merged 6 commits into from
Jul 15, 2024
Merged

44700 energy certificate data on detail pages #742

merged 6 commits into from
Jul 15, 2024

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Feb 5, 2024 •
edited
Loading

related to #718
changed log:
Update energy certificate data on detail page

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9541113757

Details

  • 10 of 15 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 79.589%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/DataView/DataDetailViewHandler.php 10 15 66.67%
Totals Coverage Status
Change from base Build 9461527919: -0.01%
Covered Lines: 8333
Relevant Lines: 10470
💛 - Coveralls

@fredericalpers fredericalpers added this to the v4.21 milestone Feb 5, 2024
@fredericalpers fredericalpers linked an issue Feb 5, 2024 that may be closed by this pull request
Energy certificate data on detail pages #718
Closed
3 tasks
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Feb 6, 2024
@fredericalpers fredericalpers added feature New feature component: property detail page Issue, Pull Request or Discussion related to property detail page labels Feb 20, 2024
@miauzjpg miauzjpg added the deploy test Triggers event to create test version label Jun 11, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-17-ga55558d3-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9461155895.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Jun 26, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.20-7-g5632e98d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9677600321.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers self-assigned this Jun 27, 2024
@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Steps to install the approved version:

  1. Download onoffice-4.20-7-g5632e98d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9834685285.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

miauzjpg
miauzjpg approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 👍

@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.20-7-g5632e98d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9935407967.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers merged commit dc44371 into master Jul 15, 2024
12 checks passed
@fredericalpers fredericalpers deleted the 44700-energy-certificate-data-on-detail-pages branch July 15, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miauzjpg miauzjpg miauzjpg approved these changes

Assignees

@fredericalpers fredericalpers

Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

Energy certificate data on detail pages
3 participants
@dai-eastgate @miauzjpg @fredericalpers