Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

45695 Critical error - ScriptLoader #767

Merged
merged 3 commits into from
Apr 8, 2024
Merged

45695 Critical error - ScriptLoader #767

merged 3 commits into from
Apr 8, 2024

Conversation

dai-eastgate
Copy link
Contributor

related to #766
changed log:
Fix critical error script loader

@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8324358595

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 79.492%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/ScriptLoader/ScriptLoaderGenericConfigurationDefault.php 0 3 0.0%
Totals Coverage Status
Change from base Build 8261543519: -0.02%
Covered Lines: 7954
Relevant Lines: 10006
💛 - Coveralls

@fredericalpers fredericalpers added this to the v4.22 milestone Mar 8, 2024
@fredericalpers fredericalpers linked an issue Mar 8, 2024 that may be closed by this pull request
#4142003: Critical error - ScriptLoader #766
Closed
3 tasks
@dai-eastgate dai-eastgate requested a review from andernath March 8, 2024 11:53
@fredericalpers fredericalpers added QA Issue or Pull request that is in review breaking change Change that causes critical errors in the plugin or its components labels Mar 11, 2024
@fredericalpers fredericalpers modified the milestones: v4.22, v4.19 Mar 11, 2024
@fredericalpers fredericalpers requested review from pospisk and removed request for andernath April 4, 2024 14:48
pospisk
pospisk approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@pospisk pospisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for Release

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Steps to install the approved version:

  1. Download onoffice-4.18.1-7-ge5f8475d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8600595158.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers merged commit 2722254 into master Apr 8, 2024
6 checks passed
@fredericalpers fredericalpers deleted the 45695-critical-error-script-loader branch April 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pospisk pospisk pospisk approved these changes

Assignees
No one assigned
Labels
breaking change Change that causes critical errors in the plugin or its components QA Issue or Pull request that is in review
Projects
None yet
Milestone
v4.19
Development

Successfully merging this pull request may close these issues.

#4142003: Critical error - ScriptLoader
4 participants
@dai-eastgate @coveralls @pospisk @fredericalpers