Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

45380 multiple contact types in form specific options #770

Merged
merged 20 commits into from
Aug 15, 2024
Merged

45380 multiple contact types in form specific options #770

merged 20 commits into from
Aug 15, 2024

Conversation

dai-eastgate
Copy link
Contributor

related to #751
changed log:
Add feature multiple contact types option in the form-specific

@coveralls
Copy link

coveralls commented Mar 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10400612577

Details

  • 32 of 56 (57.14%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 79.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderDBForm.php 4 5 80.0%
plugin/Record/RecordManagerReadForm.php 0 1 0.0%
plugin/Installer/DatabaseChanges.php 18 22 81.82%
plugin/Record/RecordManagerRead.php 0 9 0.0%
plugin/Record/RecordManagerUpdateForm.php 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
plugin/Record/RecordManagerReadForm.php 1 16.48%
Totals Coverage Status
Change from base Build 10280139031: -0.1%
Covered Lines: 8464
Relevant Lines: 10674
💛 - Coveralls

@fredericalpers fredericalpers added this to the v4.22 milestone Mar 12, 2024
@fredericalpers fredericalpers added QA Issue or Pull request that is in review UI/UX Issue, Pull Request or Discussion related to UI/UX component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms labels Mar 12, 2024
@fredericalpers fredericalpers linked an issue Mar 12, 2024 that may be closed by this pull request
Multiple contact types in form-specific options #751
Closed
2 tasks
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Jul 26, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.20-29-ga20c70fc-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10109538350.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

andernath
andernath approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@andernath andernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored and pushed some unused styling and js by myself.

@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.0-20-g6819a5e7-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10400628713.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit b47552a into master Aug 15, 2024
6 checks passed
@andernath andernath deleted the 45380-multiple-contact-types-in-form-specific-options branch August 15, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andernath andernath andernath approved these changes

Assignees
No one assigned
Labels
component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms deploy test Triggers event to create test version QA Issue or Pull request that is in review UI/UX Issue, Pull Request or Discussion related to UI/UX
Projects
None yet
Milestone
v5.1
Development

Successfully merging this pull request may close these issues.

Multiple contact types in form-specific options
4 participants
@dai-eastgate @coveralls @andernath @fredericalpers