45582 geo-position field in interest forms

[yeneastgate]

related to #757
changed log:
Fix bug geo-position display the wrong position

[coveralls]

Pull Request Test Coverage Report for Build 10090246624

Details

• 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.004%) to 79.424%

---

Totals
Change from base Build 10038829666:	0.004%
Covered Lines:	8361
Relevant Lines:	10527

---

💛 - Coveralls

[github-actions]

Steps to install the approved version:

1. Download onoffice-4.20-15-g19557214-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10042465955.
2. Unpack the downloaded file to get another .zip file.
3. Upload that inner .zip file to WordPress.

[fredericalpers]

Hi @yeneastgate,

During testing of the current changes, I encountered an issue that needs to be resolved before this pull request can be merged. The error occurs specifically on pages with property listings and results in a fatal error. The error message is as follows:

Stack trace:
#0 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites/plugin/Field/OutputFields.php(77): array_splice(Array, false, 0, Array)
#1 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites/plugin/EstateList.php(893): onOffice\WPlugin\Field\OutputFields->getVisibleFilterableFields(Object(onOffice\WPlugin\DataView\DataListView), Object(onOffice\WPlugin\Types\FieldsCollection), Object(onOffice\WPlugin\Controller\GeoPositionFieldHandler))
#2 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-personalized/templates/estate/SearchForm.php(21): onOffice\WPlugin\EstateList->getVisibleFilterableFields()
#3 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-personalized/templates/ in /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites/plugin/Field/OutputFields.php on line 77

The root cause of the issue seems to be that the array_splice() function in OutputFields.php at line 77 is receiving a boolean value instead of an integer for its second parameter. Once this is fixed, I will re-run the tests.

[yeneastgate]

@fredericalpers This error occurs when the admin estate list does not have the "Geo Position" field. I fixed it, here is the video evidence. Please test it again. Thanks!

779_videoFixBug.mp4

[github-actions]

Steps to install the approved version:

1. Download onoffice-4.20-16-g2f7ccb1a-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10090585108.
2. Unpack the downloaded file to get another .zip file.
3. Upload that inner .zip file to WordPress.

[miauzjpg]

thx!

[github-actions]

Steps to install the approved version:

1. Download onoffice-4.20-16-g2f7ccb1a-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10091477154.
2. Unpack the downloaded file to get another .zip file.
3. Upload that inner .zip file to WordPress.