Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

46121 change incorrect label text for address list #783

Merged
merged 1 commit into from
May 7, 2024
Merged

46121 change incorrect label text for address list #783

merged 1 commit into from
May 7, 2024

Conversation

dai-eastgate
Copy link
Contributor

related to #777
changed log:
Change incorrect text label for address list

@coveralls
Copy link

coveralls commented Mar 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8386300001

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.646%
Totals Coverage Status
Change from base Build 8372594133: 0.02%
Covered Lines: 8045
Relevant Lines: 10101
💛 - Coveralls

@fredericalpers fredericalpers added component: address list Issue, Pull Request or Discussion related to address lists small change A change that is small that can be dealt with during ramp-up. QA Issue or Pull request that is in review labels Mar 22, 2024
@fredericalpers fredericalpers added this to the v4.22 milestone Mar 22, 2024
@fredericalpers fredericalpers linked an issue Mar 22, 2024 that may be closed by this pull request
Change incorrect label text for address lists #777
Closed
1 task
@miauzjpg miauzjpg added the deploy test Triggers event to create test version label May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Steps to install the approved version:

  1. Download onoffice-4.18.1-8-g572922cd-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8964898028.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

miauzjpg
miauzjpg approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Steps to install the approved version:

  1. Download onoffice-4.18.1-8-g572922cd-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/8980494693.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers modified the milestones: v4.22, v4.20 May 7, 2024
@fredericalpers fredericalpers merged commit a141f59 into master May 7, 2024
9 checks passed
@fredericalpers fredericalpers deleted the 46121-change-incorrect-label-text-for-address-list branch May 7, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miauzjpg miauzjpg miauzjpg approved these changes

Assignees
No one assigned
Labels
component: address list Issue, Pull Request or Discussion related to address lists deploy test Triggers event to create test version QA Issue or Pull request that is in review small change A change that is small that can be dealt with during ramp-up.
Projects
None yet
Milestone
v4.20
Development

Successfully merging this pull request may close these issues.

Change incorrect label text for address lists
4 participants
@dai-eastgate @coveralls @miauzjpg @fredericalpers