Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

46248 resolve fatal error caused by price on request with similar estate #788

Merged
merged 12 commits into from
Aug 27, 2024
Merged

46248 resolve fatal error caused by price on request with similar estate #788

merged 12 commits into from
Aug 27, 2024

Conversation

yeneastgate
Copy link
Contributor

related to #786
changed log:
Fix bug price on request for similar estates

@coveralls
Copy link

coveralls commented Mar 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10420344164

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.305%
Totals Coverage Status
Change from base Build 10400673032: 0.01%
Covered Lines: 8465
Relevant Lines: 10674
💛 - Coveralls

@fredericalpers fredericalpers linked an issue Mar 28, 2024 that may be closed by this pull request
Resolve fatal error caused by "Price on Request" with similar estates. #786
Closed
3 tasks
@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour QA Issue or Pull request that is in review component: property detail page Issue, Pull Request or Discussion related to property detail page labels Mar 28, 2024
@fredericalpers fredericalpers added this to the v4.23 milestone Mar 28, 2024
@fredericalpers fredericalpers modified the milestones: v5.2, v5.1 Aug 2, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Aug 16, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.0-13-gefea448d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10420426375.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

miauzjpg
miauzjpg approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 🎉

@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.0-13-gefea448d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10573354345.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg merged commit 73a9805 into master Aug 27, 2024
9 checks passed
@miauzjpg miauzjpg deleted the 46248-resolve-fatal-error-caused-by-price-on-request-with-similar-estate branch August 27, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miauzjpg miauzjpg miauzjpg approved these changes

Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behaviour component: property detail page Issue, Pull Request or Discussion related to property detail page deploy test Triggers event to create test version QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.1
Development

Successfully merging this pull request may close these issues.

Resolve fatal error caused by "Price on Request" with similar estates.
5 participants
@yeneastgate @coveralls @miauzjpg @fredericalpers @dai-eastgate