Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

47254 Files are not loaded on property detail page #800

Merged
merged 6 commits into from
Jul 26, 2024
Merged

47254 Files are not loaded on property detail page #800

merged 6 commits into from
Jul 26, 2024

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Apr 22, 2024 •
edited
Loading

related to #799
changed log:
Load script for unit

@coveralls
Copy link

coveralls commented Apr 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10105162710

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 79.417%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/ScriptLoader/ScriptLoaderGenericConfigurationDefault.php 0 5 0.0%
Totals Coverage Status
Change from base Build 10091502659: -0.007%
Covered Lines: 8361
Relevant Lines: 10528
💛 - Coveralls

@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour component: property detail page Issue, Pull Request or Discussion related to property detail page component: unit list Issue, Pull Request or Discussion related to unit lists labels Apr 23, 2024
@fredericalpers fredericalpers added this to the v4.23 milestone Apr 23, 2024
@fredericalpers fredericalpers linked an issue Apr 29, 2024 that may be closed by this pull request
Files are not loaded on property detail page #799
Closed
3 tasks
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Apr 29, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Steps to install the approved version:

  1. Download onoffice-4.18.1-19-gab376158-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9004106018.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

miauzjpg
miauzjpg approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@miauzjpg miauzjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 👍

@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.18.1-19-gab376158-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9060539377.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers modified the milestones: v4.23, v4.22 Jul 16, 2024
@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Jul 26, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.20-17-g605f29db-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10108727710.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers merged commit ffd1253 into master Jul 26, 2024
6 checks passed
@fredericalpers fredericalpers deleted the 47254-files-are-not-loaded-on-property-detail-page branch July 26, 2024 09:32
@fredericalpers fredericalpers mentioned this pull request Jul 26, 2024
Closed
4 tasks
@fredericalpers fredericalpers modified the milestones: v5.1, v5.0 Jul 26, 2024
@fredericalpers fredericalpers mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miauzjpg miauzjpg miauzjpg approved these changes

Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behaviour component: property detail page Issue, Pull Request or Discussion related to property detail page component: unit list Issue, Pull Request or Discussion related to unit lists deploy test Triggers event to create test version QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

Files are not loaded on property detail page
4 participants
@dai-eastgate @coveralls @miauzjpg @fredericalpers