Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

47946 Optional writing of activities in the agents log with plugin forms & fields. #821

Merged
merged 27 commits into from
Oct 21, 2024
Merged

47946 Optional writing of activities in the agents log with plugin forms & fields. #821

merged 27 commits into from
Oct 21, 2024

Conversation

yeneastgate
Copy link
Contributor

@yeneastgate yeneastgate commented May 24, 2024 •
edited
Loading

related to #809
changed log:
Add activity option & create agents log when create forms

@coveralls
Copy link

coveralls commented May 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10698928619

Details

  • 133 of 153 (86.93%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 78.587%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/DataFormConfiguration/DataFormConfigurationFactory.php 9 10 90.0%
plugin/FormPostInterest.php 2 3 66.67%
plugin/FormPostOwner.php 2 3 66.67%
plugin/Form/FormAddressCreator.php 13 15 86.67%
plugin/Renderer/InputModelRenderer.php 0 3 0.0%
plugin/Record/RecordManagerReadForm.php 0 6 0.0%
plugin/Record/RecordManagerUpdateForm.php 0 6 0.0%
Totals Coverage Status
Change from base Build 10593215248: 0.3%
Covered Lines: 8632
Relevant Lines: 10984
💛 - Coveralls

@yeneastgate yeneastgate force-pushed the 47946-optional-writing-of-activities-in-the-agents-log-with-plugin-forms-and-fields branch from 6fff139 to 3109577 Compare May 24, 2024 09:43
@fredericalpers fredericalpers added this to the v4.24 milestone Jun 7, 2024
@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Jun 7, 2024
@fredericalpers fredericalpers linked an issue Jun 20, 2024 that may be closed by this pull request
Optional writing of activities in the agents log with plugin forms & fields. #809
Closed
4 tasks
@fredericalpers fredericalpers added feature New feature component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms labels Jul 1, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Jul 26, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.20-24-g271c21f3-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10111591293.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

@yeneastgate please resolve the conflicts here, thank you :)

@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Steps to install the approved version:

  1. Download onoffice-5.0-16-g6c5da22d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10768998261.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

@yeneastgate When activating the feature I get the following error and all settings I made are deleted:

An error occurred while saving the form. Please check whether the form name is unique.

The form definitely only exist once. Please investitage and fix the error, thank you :)

@fredericalpers fredericalpers modified the milestones: v5.3, v5.2 Sep 10, 2024
@fredericalpers
Copy link
Member

Vorgezogen auf 5.2

@yeneastgate
Copy link
Contributor Author

  • Checkbox functionality: As long as the checkbox to enable the feature is not checked, all related fields should be disabled to prevent unintended input.

@fredericalpers After checking, I cannot reproduce the error as you described. You might be experiencing browser cache issues. Could you please try clearing your browser cache?

@yeneastgate
Copy link
Contributor Author

  • Additional selection fields: Please integrate the fields Origin Contact (origincontact) and Advisory Level (advisorylevel) as selection options so that these can also be reflected in the activity.

@fredericalpers I would like to confirm with you some points:

  1. For the option "advisory level", we will implement in 2 forms: "Contact form in the detail view" and "Owner form" because only these 2 forms have "estateId".

  2. Do you agree with the placement of the fields "Origin Contact (origincontact)" and "Advisory Level (advisorylevel)" in the "Activities" box as shown in the attached image?

image

@fredericalpers
Copy link
Member

@yeneastgate please go ahead and implement the suggested changes, thank you :)

@yeneastgate
Copy link
Contributor Author

yeneastgate commented Sep 12, 2024 •
edited
Loading

@fredericalpers Currently, I have checked that when the API is called with advisorylevel for option "G".
The reasoncancellation field is used to specify the reason for cancellation.
However, when calling the API to get fields, we are unable to retrieve the values for the reasoncancellation field.

In the video, I tested that reasoncancellation only accepts newly created values.

bandicam.2024-09-12.17-52-15-379.mp4

Do we need to include reasoncancellation when selecting option G ?
If add "reasoncancellation" is require , could you provide it to "get fields" API => we can show list reason cancellation.

@fredericalpers
Copy link
Member

fredericalpers commented Sep 16, 2024 •
edited
Loading

@yeneastgate the reasoncancellation does not have to be implemented for now. I will send a ticket to the IT department. Thank you :)

Edit: It's actually not possible for this to be retrieved?

reasoncancellation
STRING. OPTIONAL. Reason of cancellation (Absagegrund). Functions together with advisory level G = Cancellation. Values can be found in enterprise under “Extras >> Settings >> Administration >> Singleselect >> Module: Property Activities” >> key field: Reason of cancellation” in the column “content”.

https://apidoc.onoffice.de/actions/datensatz-anlegen/maklerbuch-aktivitaeten/

@yeneastgate
Copy link
Contributor Author

Edit: It's actually not possible for this to be retrieved?

@fredericalpers Yes, currently I can't retrieve when using the API get field.

reasoncancellation STRING. OPTIONAL. Reason of cancellation (Absagegrund). Functions together with advisory level G = Cancellation. Values can be found in enterprise under “Extras >> Settings >> Administration >> Singleselect >> Module: Property Activities” >> key field: Reason of cancellation” in the column “content”.

https://apidoc.onoffice.de/actions/datensatz-anlegen/maklerbuch-aktivitaeten/

I've read the document but can't retrieve the "Reason of cancellation" field, as shown in the attached image.
image

@yeneastgate
Copy link
Contributor Author

  • Checkbox functionality: As long as the checkbox to enable the feature is not checked, all related fields should be disabled to prevent unintended input.
  • Additional selection fields: Please integrate the fields Origin Contact (origincontact) and Advisory Level (advisorylevel) as selection options so that these can also be reflected in the activity.

@fredericalpers I have integrated the Origin Contact (origincontact) and Advisory Level (advisorylevel) fields. Please take a look at my demo video. Thanks!

owner.form.agent.log.mp4

@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Sep 19, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.1.1-18-gf4eb83f7-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10942419287.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

@yeneastgate thank you, it seems to be working now :)

dai-eastgate and others added 5 commits September 25, 2024 16:16
@dai-eastgate
Merge branch 'master' into 47946-optional-writing-of-activities-in-th…
3213d74 
…e-agents-log-with-plugin-forms-and-fields
@andernath
Merge branch 'master' into 47946-optional-writing-of-activities-in-th…
ec6447a 
…e-agents-log-with-plugin-forms-and-fields

# Conflicts:
#	dist/checkbox.min.js
#	plugin/Installer/DatabaseChanges.php
@andernath
Fix merge conflicts
b425119 
#4310409
@yeneastgate
47946 update unit test
d9c7833
@andernath
Merge branch 'master' into 47946-optional-writing-of-activities-in-th…
a422d2c 
…e-agents-log-with-plugin-forms-and-fields
@fredericalpers
Copy link
Member

just fyi: There is currently no API call with which you can read out the possible values for rejection reasons. the hardcoded solution must suffice.

andernath
andernath reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@andernath andernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeneastgate
I finished CR, please take a look :)

js/onoffice-custom-select.js Outdated Show resolved Hide resolved
plugin/Gui/AdminPageFormSettingsContact.php Outdated Show resolved Hide resolved
css/admin.css Outdated Show resolved Hide resolved
@andernath andernath merged commit 4485f58 into master Oct 21, 2024
5 checks passed
@andernath andernath deleted the 47946-optional-writing-of-activities-in-the-agents-log-with-plugin-forms-and-fields branch October 21, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andernath andernath andernath left review comments

Assignees
No one assigned
Labels
component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.2
Development

Successfully merging this pull request may close these issues.

Optional writing of activities in the agents log with plugin forms & fields.
6 participants
@yeneastgate @coveralls @fredericalpers @andernath @dai-eastgate @pospisk