Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

48659 Optional writing of tasks in onOffice enterprise with plugin forms & fields. #826

Merged
merged 27 commits into from
Oct 29, 2024
Merged

48659 Optional writing of tasks in onOffice enterprise with plugin forms & fields. #826

merged 27 commits into from
Oct 29, 2024

Conversation

yeneastgate
Copy link
Contributor

@yeneastgate yeneastgate commented May 31, 2024 •
edited
Loading

related to #820
changed log:
Add task option & create task when create forms

@coveralls
Copy link

coveralls commented May 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10629878422

Details

  • 175 of 203 (86.21%) changed or added relevant lines in 15 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 78.428%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/DataFormConfiguration/DataFormConfigurationFactory.php 12 13 92.31%
plugin/Field/Collection/FieldLoaderSupervisorValues.php 3 4 75.0%
plugin/Form/FormAddressCreator.php 19 20 95.0%
plugin/FormPostInterest.php 2 3 66.67%
plugin/Renderer/InputModelRenderer.php 0 3 0.0%
plugin/Record/RecordManagerReadForm.php 0 6 0.0%
plugin/Record/RecordManagerUpdateForm.php 0 6 0.0%
plugin/Model/FormModelBuilder/FormModelBuilderDBForm.php 93 102 91.18%
Files with Coverage Reduction New Missed Lines %
plugin/Model/FormModelBuilder/FormModelBuilderDBForm.php 1 62.56%
Totals Coverage Status
Change from base Build 10593215248: 0.1%
Covered Lines: 8653
Relevant Lines: 11033
💛 - Coveralls

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Jun 7, 2024
@fredericalpers fredericalpers added this to the v4.24 milestone Jun 7, 2024
@fredericalpers fredericalpers linked an issue Jun 20, 2024 that may be closed by this pull request
Optional writing of tasks in onOffice enterprise with plugin forms & fields. #820
Closed
4 tasks
@fredericalpers fredericalpers added feature New feature component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms labels Jul 1, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Aug 30, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.0-13-g78402713-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10632324312.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Steps to install the approved version:

  1. Download onoffice-5.0-13-g78402713-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10665771643.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Steps to install the approved version:

  1. Download onoffice-5.0-13-g78402713-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10665915645.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

@yeneastgate Thank you for the work so far! The task creation functionality from the forms is working well. However, there are a few outstanding issues that need to be addressed:

Missing Task Type "Callback":
The task type "Callback" is not yet available. This needs to be added to ensure that users can select this type when creating tasks. Please implement this as part of the task creation process.

Field Enable/Disable Logic:
Currently, the fields related to task creation should be disabled when the checkbox for creating tasks is not selected. However, it appears that this logic isn't functioning as expected. When the checkbox is unchecked, all other fields should be disabled to prevent any accidental input. Please update the UI to reflect this behavior.

Linking Tasks to Incoming Emails:
To provide better context for tasks, they should be linked to the incoming emails from which they originate. This can be achieved by using the mailMessageId parameter, which allows the task to be associated with the specific email. Refer to the onOffice API documentation for more details on how to implement this. Ensuring that tasks are properly linked to emails will improve traceability and context.

Once these issues are addressed, the feature will be much closer to completion. Please make the necessary adjustments and let me know if you have any questions. Thanks again for your efforts

@yeneastgate
Copy link
Contributor Author

@fredericalpers I will check it.

@yeneastgate
Copy link
Contributor Author

Linking Tasks to Incoming Emails:
To provide better context for tasks, they should be linked to the incoming emails from which they originate. This can be achieved by using the mailMessageId parameter, which allows the task to be associated with the specific email. Refer to the onOffice API documentation for more details on how to implement this. Ensuring that tasks are properly linked to emails will improve traceability and context.

@fredericalpers After checking, I have the following issues:
If I need the mailMessageId, should I get it from here?

bandicam.2024-09-05.17-00-58-269.mp4

image

If this is correct, please check with the IT department to see if they can return the messageId in the response of the API "contactaddress".
Currently, the API result only returns the status of the email being successfully sent.
image

@fredericalpers
Copy link
Member

@yeneastgate please ignore the connection to the email.

For now only check the field enable/disable logic which also needs implementation in #821

Thank you :)

@yeneastgate
Copy link
Contributor Author

@fredericalpers I got it.

@yeneastgate
Copy link
Contributor Author

Missing Task Type "Callback":
The task type "Callback" is not yet available. This needs to be added to ensure that users can select this type when creating tasks. Please implement this as part of the task creation process.

@fredericalpers I fixed it. Please take a look at my video and let me know your opinions. Thanks!

PR.826.mp4

@fredericalpers
Copy link
Member

@yeneastgate thank you :) I will review this as soon as possible

@fredericalpers fredericalpers added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Sep 16, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.1-12-g70068f65-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10879273570.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers
Copy link
Member

@dai-eastgate It appears that there are merge conflicts in this branch that need to be resolved before we can proceed with the merge. Please resolve the conflicts in the affected files and update the branch. Thank you in advance :)

@dai-eastgate dai-eastgate force-pushed the 48659-optional-writing-of-tasks-in-onoffice-enterprise-with-plugin-forms-and-fields branch from e3a431b to 57b0af5 Compare October 21, 2024 09:00
@dai-eastgate dai-eastgate force-pushed the 48659-optional-writing-of-tasks-in-onoffice-enterprise-with-plugin-forms-and-fields branch from b452038 to 9b735b0 Compare October 22, 2024 10:34
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.1.4-36-gc1ed63c2-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11516981939.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath andernath merged commit 5ed9e9c into master Oct 29, 2024
2 checks passed
@andernath andernath deleted the 48659-optional-writing-of-tasks-in-onoffice-enterprise-with-plugin-forms-and-fields branch October 29, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andernath andernath andernath approved these changes

Assignees
No one assigned
Labels
component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.2
Development

Successfully merging this pull request may close these issues.

Optional writing of tasks in onOffice enterprise with plugin forms & fields.
5 participants
@yeneastgate @coveralls @fredericalpers @andernath @dai-eastgate