You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I use tab navigation on estate detail or similar estate page, unsaved changes will not be detected.
The onoffice-unsaved-changes-message.js script will be loaded at estate list, form list and address list
applicant forms: onOffice.multiselect is not a constructor
related to #697
changed log:
Use unsaved-changed-message.js only on pages with content to save
add unsaved changed message if tab navigation is used
rename multiple used variable onoffice
@dai-eastgate Please review the code (especially the admin controller file) one more time and give me your go to squash and merge this :) thank you
@fredericalpers I have reviewed the code again, and the handling of the admin controller file is very reasonable. You can go ahead and squash and merge. Here is the test video.
deploy testTriggers event to create test versionQAIssue or Pull request that is in review
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
related to #697
changed log:
Use unsaved-changed-message.js only on pages with content to save
add unsaved changed message if tab navigation is used
rename multiple used variable onoffice