Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issues with onoffice-unsaved-changed-message.js #831

Merged

Conversation

andernath
Copy link
Contributor

@andernath andernath commented Jun 5, 2024

Issues:

  • If I use tab navigation on estate detail or similar estate page, unsaved changes will not be detected.
  • The onoffice-unsaved-changes-message.js script will be loaded at estate list, form list and address list
  • applicant forms: onOffice.multiselect is not a constructor

related to #697
changed log:
Use unsaved-changed-message.js only on pages with content to save
add unsaved changed message if tab navigation is used
rename multiple used variable onoffice

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9381173112

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 79.602%

Totals Coverage Status
Change from base Build 9379876191: -0.01%
Covered Lines: 8324
Relevant Lines: 10457

💛 - Coveralls

andernath added 2 commits June 5, 2024 11:08
…-duplicated-saved-notification' into 4278931-fix-admin-settings-unsaved-changes-message

# Conflicts:
#	dist/onoffice-unsaved-changes-message.min.js
#	js/onoffice-unsaved-changes-message.js
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9381553973

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 79.602%

Totals Coverage Status
Change from base Build 9379876191: -0.01%
Covered Lines: 8324
Relevant Lines: 10457

💛 - Coveralls

@andernath andernath added this to the v4.20 milestone Jun 5, 2024
@andernath andernath added the QA Issue or Pull request that is in review label Jun 5, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

Steps to install the approved version:

  1. Download onoffice-4.19-22-g506ab6f4-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9386786776.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9386839618

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 79.602%

Totals Coverage Status
Change from base Build 9379876191: -0.01%
Covered Lines: 8324
Relevant Lines: 10457

💛 - Coveralls

@fredericalpers
Copy link
Member

@dai-eastgate Please review the code (especially the admin controller file) one more time and give me your go to squash and merge this :) thank you

Copy link

github-actions bot commented Jun 6, 2024

Steps to install the approved version:

  1. Download onoffice-4.19-24-g8962d457-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9394960382.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@dai-eastgate
Copy link
Contributor

@dai-eastgate Please review the code (especially the admin controller file) one more time and give me your go to squash and merge this :) thank you

@fredericalpers I have reviewed the code again, and the handling of the admin controller file is very reasonable. You can go ahead and squash and merge. Here is the test video.

bandicam_2024-06-06_11-12-55-028.mp4

@andernath andernath merged commit 78d974d into master Jun 6, 2024
6 checks passed
@andernath andernath deleted the 4278931-fix-admin-settings-unsaved-changes-message branch June 6, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy test Triggers event to create test version QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants