Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

48938 implement filtering in similar estate #832

Merged
merged 18 commits into from
Oct 31, 2024

Conversation

dai-eastgate
Copy link
Contributor

related to #824
changed log:
Add filter in similar estate

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9394391306

Details

  • 37 of 46 (80.43%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 79.608%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderSimilarEstateSettings.php 29 38 76.32%
Totals Coverage Status
Change from base Build 9379876191: -0.008%
Covered Lines: 8362
Relevant Lines: 10504

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9396655640

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 42 of 46 (91.3%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 79.642%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderSimilarEstateSettings.php 34 38 89.47%
Files with Coverage Reduction New Missed Lines %
plugin/Controller/AdminViewController.php 11 94.15%
Totals Coverage Status
Change from base Build 9379876191: 0.03%
Covered Lines: 8360
Relevant Lines: 10497

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9397186030

Details

  • 42 of 46 (91.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 79.642%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderSimilarEstateSettings.php 34 38 89.47%
Totals Coverage Status
Change from base Build 9395730264: 0.04%
Covered Lines: 8360
Relevant Lines: 10497

💛 - Coveralls

@fredericalpers fredericalpers added this to the v4.25 milestone Jun 7, 2024
@fredericalpers fredericalpers added QA Issue or Pull request that is in review component: property list Issue, Pull Request or Discussion related to property lists labels Jun 7, 2024
@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9541228896

Details

  • 42 of 46 (91.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 79.642%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderSimilarEstateSettings.php 34 38 89.47%
Totals Coverage Status
Change from base Build 9461527919: 0.04%
Covered Lines: 8360
Relevant Lines: 10497

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9575911922

Details

  • 42 of 46 (91.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 79.663%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderSimilarEstateSettings.php 34 38 89.47%
Totals Coverage Status
Change from base Build 9563894875: 0.04%
Covered Lines: 8375
Relevant Lines: 10513

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9609479131

Details

  • 42 of 46 (91.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 79.663%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderSimilarEstateSettings.php 34 38 89.47%
Totals Coverage Status
Change from base Build 9575992260: 0.04%
Covered Lines: 8375
Relevant Lines: 10513

💛 - Coveralls

@fredericalpers fredericalpers linked an issue Jul 1, 2024 that may be closed by this pull request
1 task
@fredericalpers fredericalpers added the feature New feature label Jul 1, 2024
Copy link

Pull Request Test Coverage Report for Build 10607632000

Details

  • 42 of 46 (91.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 78.328%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Model/FormModelBuilder/FormModelBuilderSimilarEstateSettings.php 34 38 89.47%
Totals Coverage Status
Change from base Build 10593215248: 0.04%
Covered Lines: 8515
Relevant Lines: 10871

💛 - Coveralls

@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Sep 30, 2024
Copy link

Steps to install the approved version:

  1. Download onoffice-5.1.2-15-g2594fb9f-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11107746155.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers modified the milestones: v5.4, v5.3 Oct 7, 2024
@andernath andernath merged commit 88c50f0 into master Oct 31, 2024
2 checks passed
@andernath andernath deleted the 48938-implement-filtering-in-similar-estate branch October 31, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: property list Issue, Pull Request or Discussion related to property lists deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement filtering in similar estates
5 participants