Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

43299 Hotfix error multiple select for issues with onoffice-custom-select.js #834

Merged

Conversation

yeneastgate
Copy link
Contributor

related to #700
changed log:
Fix bug multiple selection

@dai-eastgate dai-eastgate changed the title 43299 hotfix error multiple select 43299 Hotfix error multiple select for issues with onoffice-custom-select.js Jun 7, 2024
@yeneastgate
Copy link
Contributor Author

yeneastgate commented Jun 7, 2024

@fredericalpers While fixing conflicts and merging in the master, I found a bug related to multiple selections in issue #700, see video evidence below. Please check and merge it as soon as possible. Thanks!

fixbug43299.mp4

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9413154728

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.602%

Totals Coverage Status
Change from base Build 9395730264: 0.0%
Covered Lines: 8324
Relevant Lines: 10457

💛 - Coveralls

@fredericalpers fredericalpers requested a review from andernath June 7, 2024 07:49
@fredericalpers fredericalpers added this to the v4.25 milestone Jun 7, 2024
@fredericalpers fredericalpers added the bug Indicates an unexpected problem or unintended behaviour label Jun 7, 2024
@fredericalpers
Copy link
Member

@andernath Bitte prüfen :)

Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-19-g91a9f110-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9461199988.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@andernath
Copy link
Contributor

andernath commented Jun 11, 2024

Review and Test ✔✔
Add this to 4.20 because bug occurred in this version

FYI @fredericalpers

@andernath andernath merged commit 063933e into master Jun 11, 2024
9 checks passed
@andernath andernath deleted the 43299-hotfix-settings-pages-property-list-loading-time branch June 11, 2024 07:39
@andernath andernath modified the milestones: v4.25, v4.20 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants